Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754059AbbKWJ2g (ORCPT ); Mon, 23 Nov 2015 04:28:36 -0500 Received: from mail-pa0-f52.google.com ([209.85.220.52]:36307 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751251AbbKWJ2c (ORCPT ); Mon, 23 Nov 2015 04:28:32 -0500 From: Saurabh Sengar To: rpurdie@rpsys.net, j.anaszewski@samsung.com, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Saurabh Sengar Subject: [PATCH] leds/powernv : removing NULL check Date: Mon, 23 Nov 2015 14:58:16 +0530 Message-Id: <1448270896-23955-1-git-send-email-saurabh.truth@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1018 Lines: 30 no need to explicitly check for pointer to be null, of_prop_next_string anyways return NULL, if passed pointer is NULL and hence loop will continue Signed-off-by: Saurabh Sengar --- drivers/leds/leds-powernv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/leds/leds-powernv.c b/drivers/leds/leds-powernv.c index 1e75e1f..bc2d76e 100644 --- a/drivers/leds/leds-powernv.c +++ b/drivers/leds/leds-powernv.c @@ -256,8 +256,6 @@ static int powernv_led_classdev(struct platform_device *pdev, for_each_child_of_node(led_node, np) { p = of_find_property(np, "led-types", NULL); - if (!p) - continue; while ((cur = of_prop_next_string(p, cur)) != NULL) { powernv_led = devm_kzalloc(dev, sizeof(*powernv_led), -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/