Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753529AbbKWJjy (ORCPT ); Mon, 23 Nov 2015 04:39:54 -0500 Received: from regular1.263xmail.com ([211.150.99.133]:49323 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752643AbbKWJjx (ORCPT ); Mon, 23 Nov 2015 04:39:53 -0500 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:S;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-DNS-TYPE: 0 Message-ID: <5652DEDD.60603@rock-chips.com> Date: Mon, 23 Nov 2015 17:39:41 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Liviu Dudau , Russell King , =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= , Philipp Zabel , Daniel Vetter , David Airlie , Eric Anholt CC: linux-rockchip , dri-devel , LAKML , LKML Subject: Re: [PATCH v2 2/2] drm/rockchip: Convert the probe function to the generic drm_of_component_probe() References: <1448029325-14602-1-git-send-email-Liviu.Dudau@arm.com> <1448029325-14602-3-git-send-email-Liviu.Dudau@arm.com> In-Reply-To: <1448029325-14602-3-git-send-email-Liviu.Dudau@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 721 Lines: 22 On 2015年11月20日 22:22, Liviu Dudau wrote: > Initial attempt to convert rockchip to drm_of_component_probe() missed the > difference between ports and encoders when using the compare_of() function. > Now that drm_of_component_probe() has been enhanced, let's try again the > conversion. > > Signed-off-by: Liviu Dudau Looks good for me, and it works on popmetal board, so Acked-by: Mark Yao Thanks. -- Mark Yao -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/