Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754451AbbKWJuw (ORCPT ); Mon, 23 Nov 2015 04:50:52 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:37139 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753618AbbKWJuv (ORCPT ); Mon, 23 Nov 2015 04:50:51 -0500 Date: Mon, 23 Nov 2015 10:50:49 +0100 From: Michal Hocko To: Jeff Layton Cc: Andrew Morton , Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: fix up sparse warning in gfpflags_allow_blocking Message-ID: <20151123095048.GB21436@dhcp22.suse.cz> References: <1448030459-20990-1-git-send-email-jeff.layton@primarydata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448030459-20990-1-git-send-email-jeff.layton@primarydata.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1296 Lines: 36 On Fri 20-11-15 09:40:59, Jeff Layton wrote: > sparse says: > > include/linux/gfp.h:274:26: warning: incorrect type in return expression (different base types) > include/linux/gfp.h:274:26: expected bool > include/linux/gfp.h:274:26: got restricted gfp_t > > ...add a forced cast to silence the warning. > > Cc: Mel Gorman > Signed-off-by: Jeff Layton > --- > include/linux/gfp.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index 6523109e136d..8942af0813e3 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -271,7 +271,7 @@ static inline int gfpflags_to_migratetype(const gfp_t gfp_flags) > > static inline bool gfpflags_allow_blocking(const gfp_t gfp_flags) > { > - return gfp_flags & __GFP_DIRECT_RECLAIM; > + return (bool __force)(gfp_flags & __GFP_DIRECT_RECLAIM); Wouldn't (gfp_flags & __GFP_DIRECT_RECLAIM) != 0 be easier/better to read? -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/