Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754316AbbKWK16 (ORCPT ); Mon, 23 Nov 2015 05:27:58 -0500 Received: from lhrrgout.huawei.com ([194.213.3.17]:11018 "EHLO lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754027AbbKWK1y convert rfc822-to-8bit (ORCPT ); Mon, 23 Nov 2015 05:27:54 -0500 From: Gabriele Paoloni To: Arnd Bergmann , Stanimir Varbanov CC: "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-pci@vger.kernel.org" , Bjorn Helgaas , "Srinivas Kandagatla" , Rob Herring , Rob Herring , Mark Rutland , Pawel Moll , Ian Campbell , Jingoo Han , "Pratyush Anand" , Bjorn Andersson Subject: RE: [PATCH v3 1/6] PCI: designware: remove wrong io_base assignment Thread-Topic: [PATCH v3 1/6] PCI: designware: remove wrong io_base assignment Thread-Index: AQHRJdGix8FaGxfxQkCYB4RESh7xjJ6pX64AgAAGRYA= Date: Mon, 23 Nov 2015 10:27:36 +0000 Message-ID: References: <44d133d5ebd4f7b9e8b817aa8bae12f690e70000.1448270813.git.stanimir.varbanov@linaro.org> <6048361.Am0T3g77Bd@wuerfel> In-Reply-To: <6048361.Am0T3g77Bd@wuerfel> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.137.242] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.5652EA22.0076,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: b264140c8f7392ebcf6fe49d36250f0b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2846 Lines: 78 Hi Stanimir, Many Thanks for this fix > -----Original Message----- > From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel- > owner@vger.kernel.org] On Behalf Of Arnd Bergmann > Sent: 23 November 2015 10:00 > To: Stanimir Varbanov > Cc: linux-arm-msm@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; devicetree@vger.kernel.org; linux- > pci@vger.kernel.org; Bjorn Helgaas; Srinivas Kandagatla; Rob Herring; Rob > Herring; Mark Rutland; Pawel Moll; Ian Campbell; Jingoo Han; Pratyush Anand; > Bjorn Andersson > Subject: Re: [PATCH v3 1/6] PCI: designware: remove wrong io_base assignment > > On Monday 23 November 2015 11:28:58 Stanimir Varbanov wrote: > > The io_base is used to keep the cpu physical address parsed > > from ranges dt property. After issue pci_remap_iospace the > > io_base has been assigned with io->start, which is not correct > > cause io->start is a PCI bus address. > > > > Signed-off-by: Stanimir Varbanov > > --- > > drivers/pci/host/pcie-designware.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie- > designware.c > > index 540f077c37ea..02a7452bdf23 100644 > > --- a/drivers/pci/host/pcie-designware.c > > +++ b/drivers/pci/host/pcie-designware.c > > @@ -440,7 +440,6 @@ int dw_pcie_host_init(struct pcie_port *pp) > > ret, pp->io); > > continue; > > } > > - pp->io_base = pp->io->start; > > break; > > case IORESOURCE_MEM: > > pp->mem = win->res; > > I was surprised to see such an obvious bug here, as we had spent a lot of > time trying to get it right. However, it broke only recently and it's > worth mentioning what commit did it, so Looking at "[PATCH v12 0/8] PCI: hisi: Add PCIe host support for HiSilicon SoC Hip05": actually the bug came in as patch 3/6 of v11 patchset split [...] Change from v11: - Split 3/6 in v11 to 3/8, 4/8, 5/8 in v12. [...] This was not present in v11...sorry about this. Gab > > Fixes: 0021d22b73d6 ("PCI: designware: Use of_pci_get_host_bridge_resources() > to parse DT") > Reviewed-by: Arnd Bergmann > > The bug is present in 4.4-rc1 and we should get your fix merged into 4.4 > as well, while all the other patches in your series are presumably for 4.5. > > Arnd > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/