Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754046AbbKWK1v (ORCPT ); Mon, 23 Nov 2015 05:27:51 -0500 Received: from smtp105.iad3a.emailsrvr.com ([173.203.187.105]:52020 "EHLO smtp105.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753566AbbKWK1u (ORCPT ); Mon, 23 Nov 2015 05:27:50 -0500 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH] staging: comedi: Coding style warning fix for block comments To: Andy Shevchenko , Jitendra Kumar Khasdev References: <1448219975-7543-1-git-send-email-jitendra.khasdev@hotwaxsystems.com> Cc: hsweeten@visionengravers.com, Greg Kroah-Hartman , devel@driverdev.osuosl.org, "linux-kernel@vger.kernel.org" , Jitendra Kumar Khasdev From: Ian Abbott Message-ID: <5652EA23.8000703@mev.co.uk> Date: Mon, 23 Nov 2015 10:27:47 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1638 Lines: 50 On 22/11/15 19:24, Andy Shevchenko wrote: > On Sun, Nov 22, 2015 at 9:19 PM, Jitendra Kumar Khasdev > wrote: >> This patch is to comedilib.h file that fixes up following warnings >> reported by checkpatch.pl : >> I) Block comments use * on subsequent lines >> >> Signed-off-by: Jitendra Kumar Khasdev >> --- >> drivers/staging/comedi/comedilib.h | 32 ++++++++++++++++---------------- >> 1 file changed, 16 insertions(+), 16 deletions(-) >> >> diff --git a/drivers/staging/comedi/comedilib.h b/drivers/staging/comedi/comedilib.h >> index 56baf85..ccbe17b 100644 >> --- a/drivers/staging/comedi/comedilib.h >> +++ b/drivers/staging/comedi/comedilib.h >> @@ -1,20 +1,20 @@ >> /* >> - linux/include/comedilib.h > > I don't think the file name is somehow useful here. To be fair, this patch is merely fixing the comment style, rather than changing the contents. Although I wouldn't mind if this line were changed, especially as the existing pathname is wrong. It could be changed to be just the basename of the header file like this: * comedilib.h which is similar to the header comment in comedidev.h. > > >> - header file for kcomedilib > > Perhaps > > * Header file for kcomedilib. No objections there. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/