Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753207AbbKWLRV (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 Nov 2015 06:17:21 -0500
Received: from mailout2.w1.samsung.com ([210.118.77.12]:10481 "EHLO
	mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751485AbbKWLRT (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 Nov 2015 06:17:19 -0500
X-AuditID: cbfec7f5-f79b16d000005389-5e-5652f5bc138c
Message-id: <5652F5BB.8090205@samsung.com>
Date: Mon, 23 Nov 2015 12:17:15 +0100
From: Jacek Anaszewski <j.anaszewski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804
 Thunderbird/17.0.8
MIME-version: 1.0
To: "Kim, Milo" <milo.kim@ti.com>
Cc: devicetree@vger.kernel.org, lee.jones@linaro.org,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH RESEND 15/16] leds: add LM3633 driver
References: <1446441875-1256-1-git-send-email-milo.kim@ti.com>
 <1446441875-1256-16-git-send-email-milo.kim@ti.com>
 <5638DD99.9070502@samsung.com> <56419F0C.90009@ti.com>
 <564EE66C.5010709@samsung.com> <56525262.60308@ti.com>
In-reply-to: <56525262.60308@ti.com>
Content-type: text/plain; charset=windows-1252; format=flowed
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBLMWRmVeSWpSXmKPExsVy+t/xq7p7vgaFGZxYbmUx/8g5Vov7X48y
	WlzeNYfNYuubdYwWy3+tY3Fg9bhzbQ+bx/Eb25k8Pm+SC2CO4rJJSc3JLEst0rdL4Mo4+1ig
	YJ9wxZffs5gaGNv4uxg5OSQETCTebdvADmGLSVy4t56ti5GLQ0hgKaPExJltzBDOM0aJvrb7
	rCBVvAJaEmdvdbOB2CwCqhLTu64xgthsAoYSP1+8ZgKxRQUiJP6c3gdVLyjxY/I9FhBbREBR
	4uOZXWD1zAIFEnP2LAOzhQUsJW53/mKEWzZl606wkzgFVCQmTm1mg2iwlVjwfh0LhC0vsXnN
	W+YJjAKzkOyYhaRsFpKyBYzMqxhFU0uTC4qT0nON9IoTc4tL89L1kvNzNzFCwvfrDsalx6wO
	MQpwMCrx8GroB4UJsSaWFVfmHmKU4GBWEuE9shUoxJuSWFmVWpQfX1Sak1p8iFGag0VJnHfm
	rvchQgLpiSWp2ampBalFMFkmDk6pBkaP52vm7cmdsjXeZFFv8Iurr38/uqyaM99intW/D9X6
	E9xKpryQbf61h/GsUa1XSPmaHW8f37maZPLDSmOlyNo975hruA++n+b19v9tFU6Otr39895+
	Yj0h7Tjt9j5LH672i5zFc10a6mITzq2tsElmjli08dY955iEHoNVIYadAb+/lu6/dqpOiaU4
	I9FQi7moOBEAqMNP0VsCAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2672
Lines: 72

Hi Milo,

On 11/23/2015 12:40 AM, Kim, Milo wrote:
> Hi Jacek,
>
> On 11/20/2015 6:22 PM, Jacek Anaszewski wrote:
>> On 11/10/2015 08:38 AM, Kim, Milo wrote:
>> [...]
>>>>> +                cat /sys/class/leds/<led>/pattern_levels
>>>>> +                low brightness: 0, high brightness: 255
>>>>> +
>>>>> +What:        /sys/class/leds/<led>/run_pattern
>>>>> +Date:        Oct 2015
>>>>> +KernelVersion:    4.3
>>>>> +Contact:    Milo Kim <milo.kim@ti.com>
>>>>> +Description:    write only
>>>>> +                After 'pattern_times' and 'pattern_levels' are
>>>>> updated,
>>>>> +                run the pattern by writing 1 to 'run_pattern'.
>>>>> +                To stop running pattern, writes 0 to 'run_pattern'.
>>>>
>>>> I wonder how registering an in-driver trigger would work. It would
>>>> allow for hiding above pattern attributes when the trigger is inactive,
>>>> and thus making the sysfs interface more transparent. You could avoid
>>>> the need for run_pattern attribute, as setting the trigger would itself
>>>> activate the pattern, and setting brightness to 0 would turn it off.
>>>
>>> I like this idea, let me try to fix it.
>>
>> After thinking it over, I came to conclusion that implementing it as
>> an in-driver trigger is not a proper way to go, since triggers are
>> defined as kernel based source of LED events.
>>
>> This is somehow abused in case of timer trigger which takes hardware
>> blinking feature as a first choice and applies software blinking as
>> a fallback only. To be consistent with that, we could go for adding
>> generic pattern trigger and add a led_pattern_set() API, similarly
>> to existing led_blink_set().
>>
>> The problem is that different LED controllers may implement blinking
>> patterns that are configured with different set of parameters. This
>> subject would definitely require thorough analysis.
>>
>> For now, please just expose pattern settings as separate sysfs
>> attributes of a LED class device.
>>
>
> Thanks for your suggestion.
> Then, LM3633 LED driver will support 8 device attributes.
>
>      pattern_time_delay
>      pattern_time_rise
>      pattern_time_high
>      pattern_time_fall
>      pattern_time_low
>      pattern_brightness_low
>      pattern_brightness_high
>      pattern_run_pattern
>
> Details will be updated in
> Documentation/ABI/testing/sysfs-class-led-lm3633.

OK, it looks reasonable.

-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/