Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754627AbbKWOK6 (ORCPT ); Mon, 23 Nov 2015 09:10:58 -0500 Received: from mail-pa0-f66.google.com ([209.85.220.66]:34296 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753743AbbKWOK5 (ORCPT ); Mon, 23 Nov 2015 09:10:57 -0500 From: Saurabh Sengar To: l.majewski@samsung.com, rui.zhang@intel.com, edubezval@gmail.com, kgene@kernel.org, k.kozlowski@samsung.com, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Saurabh Sengar Subject: [PATCH] thermal: exynos: use of_property_read_u8() Date: Mon, 23 Nov 2015 19:40:41 +0530 Message-Id: <1448287841-4816-1-git-send-email-saurabh.truth@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2766 Lines: 74 use of_property_read_u8() for u8 variables, also changed the return type to void as this function return type is nowhere used. Signed-off-by: Saurabh Sengar --- drivers/thermal/samsung/exynos_tmu.c | 30 +++++++++++++----------------- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index fa61eff..b692c95 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -1128,20 +1128,16 @@ static int exynos_of_get_soc_type(struct device_node *np) return -EINVAL; } -static int exynos_of_sensor_conf(struct device_node *np, +static void exynos_of_sensor_conf(struct device_node *np, struct exynos_tmu_platform_data *pdata) { - u32 value; - int ret; - of_node_get(np); - ret = of_property_read_u32(np, "samsung,tmu_gain", &value); - pdata->gain = (u8)value; - of_property_read_u32(np, "samsung,tmu_reference_voltage", &value); - pdata->reference_voltage = (u8)value; - of_property_read_u32(np, "samsung,tmu_noise_cancel_mode", &value); - pdata->noise_cancel_mode = (u8)value; + of_property_read_u8(np, "samsung,tmu_gain", &pdata->gain); + of_property_read_u8(np, "samsung,tmu_reference_voltage", + &pdata->reference_voltage); + of_property_read_u8(np, "samsung,tmu_noise_cancel_mode", + &pdata->noise_cancel_mode); of_property_read_u32(np, "samsung,tmu_efuse_value", &pdata->efuse_value); @@ -1150,18 +1146,18 @@ static int exynos_of_sensor_conf(struct device_node *np, of_property_read_u32(np, "samsung,tmu_max_efuse_value", &pdata->max_efuse_value); - of_property_read_u32(np, "samsung,tmu_first_point_trim", &value); - pdata->first_point_trim = (u8)value; - of_property_read_u32(np, "samsung,tmu_second_point_trim", &value); - pdata->second_point_trim = (u8)value; - of_property_read_u32(np, "samsung,tmu_default_temp_offset", &value); - pdata->default_temp_offset = (u8)value; + of_property_read_u8(np, "samsung,tmu_first_point_trim", + &pdata->first_point_trim); + of_property_read_u8(np, "samsung,tmu_second_point_trim", + &pdata->second_point_trim); + of_property_read_u8(np, "samsung,tmu_default_temp_offset", + &pdata->default_temp_offset); of_property_read_u32(np, "samsung,tmu_cal_type", &pdata->cal_type); of_property_read_u32(np, "samsung,tmu_cal_mode", &pdata->cal_mode); of_node_put(np); - return 0; + return; } static int exynos_map_dt_data(struct platform_device *pdev) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/