Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753658AbbKWOla (ORCPT ); Mon, 23 Nov 2015 09:41:30 -0500 Received: from eusmtp01.atmel.com ([212.144.249.242]:46848 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753091AbbKWOl2 (ORCPT ); Mon, 23 Nov 2015 09:41:28 -0500 Subject: Re: [PATCH 1/2] dmaengine: at_xdmac: fix macro typo To: Ludovic Desroches , References: <1448284184-15171-1-git-send-email-ludovic.desroches@atmel.com> CC: , , From: Nicolas Ferre Organization: atmel Message-ID: <565325A9.6020604@atmel.com> Date: Mon, 23 Nov 2015 15:41:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1448284184-15171-1-git-send-email-ludovic.desroches@atmel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1540 Lines: 38 Le 23/11/2015 14:09, Ludovic Desroches a ?crit : > Fix typo in a macro which was not used until now. It explains why there > is no error at compilation time. > > Signed-off-by: Ludovic Desroches > Fixes: e1f7c9eee707 "dmaengine: at_xdmac: creation of the atmel eXtended > DMA Controller driver" > Cc: stable@vger.kernel.org # 3.19 and later Acked-by: Nicolas Ferre > --- > drivers/dma/at_xdmac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c > index 7f039de..d09277f 100644 > --- a/drivers/dma/at_xdmac.c > +++ b/drivers/dma/at_xdmac.c > @@ -156,7 +156,7 @@ > #define AT_XDMAC_CC_WRIP (0x1 << 23) /* Write in Progress (read only) */ > #define AT_XDMAC_CC_WRIP_DONE (0x0 << 23) > #define AT_XDMAC_CC_WRIP_IN_PROGRESS (0x1 << 23) > -#define AT_XDMAC_CC_PERID(i) (0x7f & (h) << 24) /* Channel Peripheral Identifier */ > +#define AT_XDMAC_CC_PERID(i) (0x7f & (i) << 24) /* Channel Peripheral Identifier */ > #define AT_XDMAC_CDS_MSP 0x2C /* Channel Data Stride Memory Set Pattern */ > #define AT_XDMAC_CSUS 0x30 /* Channel Source Microblock Stride */ > #define AT_XDMAC_CDUS 0x34 /* Channel Destination Microblock Stride */ > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/