Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753548AbbKWRDO (ORCPT ); Mon, 23 Nov 2015 12:03:14 -0500 Received: from fieldses.org ([173.255.197.46]:42863 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972AbbKWRDM (ORCPT ); Mon, 23 Nov 2015 12:03:12 -0500 Date: Mon, 23 Nov 2015 12:03:11 -0500 From: "J. Bruce Fields" To: Jeff Layton Cc: Julia Lawall , kernel-janitors@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nfsd: recover: constify nfsd4_client_tracking_ops structures Message-ID: <20151123170311.GB10986@fieldses.org> References: <1448176930-15173-1-git-send-email-Julia.Lawall@lip6.fr> <20151122072512.2b6b3518@tlielax.poochiereds.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151122072512.2b6b3518@tlielax.poochiereds.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2569 Lines: 74 On Sun, Nov 22, 2015 at 07:25:12AM -0500, Jeff Layton wrote: > On Sun, 22 Nov 2015 08:22:10 +0100 > Julia Lawall wrote: > > > The nfsd4_client_tracking_ops structures are never modified, so declare > > them as const. > > > > Done with the help of Coccinelle. > > > > Signed-off-by: Julia Lawall > > > > --- > > fs/nfsd/netns.h | 2 +- > > fs/nfsd/nfs4recover.c | 6 +++--- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/fs/nfsd/netns.h b/fs/nfsd/netns.h > > index d8b16c2..5fbf3bb 100644 > > --- a/fs/nfsd/netns.h > > +++ b/fs/nfsd/netns.h > > @@ -92,7 +92,7 @@ struct nfsd_net { > > > > struct file *rec_file; > > bool in_grace; > > - struct nfsd4_client_tracking_ops *client_tracking_ops; > > + const struct nfsd4_client_tracking_ops *client_tracking_ops; > > > > time_t nfsd4_lease; > > time_t nfsd4_grace; > > diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c > > index e3d4709..79f0307 100644 > > --- a/fs/nfsd/nfs4recover.c > > +++ b/fs/nfsd/nfs4recover.c > > @@ -631,7 +631,7 @@ nfsd4_check_legacy_client(struct nfs4_client *clp) > > return -ENOENT; > > } > > > > -static struct nfsd4_client_tracking_ops nfsd4_legacy_tracking_ops = { > > +static const struct nfsd4_client_tracking_ops nfsd4_legacy_tracking_ops = { > > .init = nfsd4_legacy_tracking_init, > > .exit = nfsd4_legacy_tracking_exit, > > .create = nfsd4_create_clid_dir, > > @@ -1050,7 +1050,7 @@ out_err: > > printk(KERN_ERR "NFSD: Unable to end grace period: %d\n", ret); > > } > > > > -static struct nfsd4_client_tracking_ops nfsd4_cld_tracking_ops = { > > +static const struct nfsd4_client_tracking_ops nfsd4_cld_tracking_ops = { > > .init = nfsd4_init_cld_pipe, > > .exit = nfsd4_remove_cld_pipe, > > .create = nfsd4_cld_create, > > @@ -1394,7 +1394,7 @@ nfsd4_umh_cltrack_grace_done(struct nfsd_net *nn) > > kfree(legacy); > > } > > > > -static struct nfsd4_client_tracking_ops nfsd4_umh_tracking_ops = { > > +static const struct nfsd4_client_tracking_ops nfsd4_umh_tracking_ops = { > > .init = nfsd4_umh_cltrack_init, > > .exit = NULL, > > .create = nfsd4_umh_cltrack_create, > > > > Looks good to me. > > Reviewed-by: Jeff Layton Thanks, applying for 4.5. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/