Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932133AbbKWRjQ (ORCPT ); Mon, 23 Nov 2015 12:39:16 -0500 Received: from www.linutronix.de ([62.245.132.108]:45914 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932104AbbKWRjP (ORCPT ); Mon, 23 Nov 2015 12:39:15 -0500 Date: Mon, 23 Nov 2015 18:38:28 +0100 (CET) From: Thomas Gleixner To: Marc Zyngier cc: Jiang Liu , Bjorn Helgaas , Phil Edworthy , linux-kernel@vger.kernel.org, Wolfram Sang Subject: Re: [PATCH] PCI: MSI: Only use the generic MSI layer when domain is hierarchical In-Reply-To: <1448288826-19058-1-git-send-email-marc.zyngier@arm.com> Message-ID: References: <1448288826-19058-1-git-send-email-marc.zyngier@arm.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1129 Lines: 25 On Mon, 23 Nov 2015, Marc Zyngier wrote: > Since d8a1cb757550 ("PCI/MSI: Let pci_msi_get_domain use struct > device::msi_domain"), we use the MSI domain associated to the PCI device. > > But finding a MSI domain doesn't mean that the domain is implemented > using the generic MSI domain API, and a number of MSI controllers > are still using the arch_setup_msi_irq/arch_teardown_msi_irqs. > > In order to avoid a firework on these systems, check that the domain > we just obtained is hierarchical. If not, don't use the generic MSI > stuff and stick with the old one. Not pretty, but reliable. > > Another insentive to rework those drivers and phase out this API. > > Reported-by: Phil Edworthy > Tested-by: Phil Edworthy > Signed-off-by: Marc Zyngier Acked-by: Thomas Gleixner -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/