Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754468AbbKWSFe (ORCPT ); Mon, 23 Nov 2015 13:05:34 -0500 Received: from seldrel01.sonyericsson.com ([37.139.156.2]:18824 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752076AbbKWSFc (ORCPT ); Mon, 23 Nov 2015 13:05:32 -0500 Subject: Re: [PATCH v4 3/3] usb: chipidea: register driver as a peripheral with the phy To: Peter Chen References: <1448063240-2739-1-git-send-email-tim.bird@sonymobile.com> <1448063240-2739-3-git-send-email-tim.bird@sonymobile.com> <20151123082929.GA8193@shlinux2> CC: "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "gregkh@linuxfoundation.org" , "balbi@ti.com" , =?UTF-8?Q?Andersson=2c_Bj=c3=b6rn?= , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tbird20d@gmail.com" From: Tim Bird Message-ID: <56535563.6010902@sonymobile.com> Date: Mon, 23 Nov 2015 10:05:23 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151123082929.GA8193@shlinux2> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1835 Lines: 52 On 11/23/2015 12:29 AM, Peter Chen wrote: > On Fri, Nov 20, 2015 at 03:47:20PM -0800, Tim Bird wrote: >> Register the chipidea driver with the phy, so that the phy >> driver can kick the gadget driver when it resumes from low power. >> The phy-msm-usb (Qualcomm) driver requires this in order to >> recover gadget operation after you disconnect the USB cable >> and reconnect it. >> >> Signed-off-by: Tim Bird >> --- >> drivers/usb/chipidea/udc.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c >> index 8223fe7..06234cd 100644 >> --- a/drivers/usb/chipidea/udc.c >> +++ b/drivers/usb/chipidea/udc.c >> @@ -1890,6 +1890,12 @@ static int udc_start(struct ci_hdrc *ci) >> >> ci->gadget.ep0 = &ci->ep0in->ep; >> >> + if (ci->usb_phy) { >> + retval = otg_set_peripheral(ci->usb_phy->otg, &ci->gadget); >> + if (retval) >> + goto destroy_eps; >> + } >> + >> retval = usb_add_gadget_udc(dev, &ci->gadget); >> if (retval) >> goto destroy_eps; > > Hi Tim, > > I am afraid it can't work for current chipidea framework (find this > problem after testing), the chipidea core manages its host and device > function using its own API start/stop, it does not define struct usb_otg > APIs. In fact, it is not reasonable control host and device function > at PHY driver. OK. I'm going to re-evaluate the phy-msm-usb.c code, and try to figure out what it should look like under the current framework. Thanks for looking at it and testing it. I may have questions as I go. -- Tim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/