Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755328AbbKWSFy (ORCPT ); Mon, 23 Nov 2015 13:05:54 -0500 Received: from mail-oi0-f42.google.com ([209.85.218.42]:33841 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751872AbbKWSFx (ORCPT ); Mon, 23 Nov 2015 13:05:53 -0500 MIME-Version: 1.0 In-Reply-To: <1448295329-3087-1-git-send-email-saurabh.truth@gmail.com> References: <201511232333.kj6JWXch%fengguang.wu@intel.com> <1448295329-3087-1-git-send-email-saurabh.truth@gmail.com> Date: Mon, 23 Nov 2015 19:05:52 +0100 X-Google-Sender-Auth: 8xw8gkLF3kWg1GtESBIHsE-VwPU Message-ID: Subject: Re: [PATCH v2] mtd: nand: use of_property_read_u8() From: Geert Uytterhoeven To: Saurabh Sengar Cc: =?UTF-8?B?TcOlbnMgUnVsbGfDpXJk?= , David Woodhouse , Brian Norris , MTD Maling List , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3234 Lines: 78 Hi Saurab, On Mon, Nov 23, 2015 at 5:15 PM, Saurabh Sengar wrote: > use of_property_read_u8() for u8 values Why are you making this change? Have you tested this? drivers/of/base.c says * dts entry of array should be like: * property = /bits/ 8 <0x50 0x60 0x70>; but Documentation/devicetree/bindings/mtd/orion-nand.txt doesn't say anything about the "/bits/ 8" part, thus "normal" 32-bit cells are assumed. > Signed-off-by: Saurabh Sengar > --- > v2 : added the missed semi colon > drivers/mtd/nand/orion_nand.c | 22 +++++++--------------- > 1 file changed, 7 insertions(+), 15 deletions(-) > > diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c > index ee83749..0cbebc5 100644 > > --- a/drivers/mtd/nand/orion_nand.c > +++ b/drivers/mtd/nand/orion_nand.c > @@ -83,7 +83,6 @@ static int __init orion_nand_probe(struct platform_device *pdev) > struct clk *clk; > void __iomem *io_base; > int ret = 0; > - u32 val = 0; > > nc = devm_kzalloc(&pdev->dev, > sizeof(struct nand_chip) + sizeof(struct mtd_info), > @@ -103,22 +102,15 @@ static int __init orion_nand_probe(struct platform_device *pdev) > GFP_KERNEL); > if (!board) > return -ENOMEM; > - if (!of_property_read_u32(pdev->dev.of_node, "cle", &val)) > - board->cle = (u8)val; > - else > - board->cle = 0; > - if (!of_property_read_u32(pdev->dev.of_node, "ale", &val)) > - board->ale = (u8)val; > - else > + of_property_read_u8(pdev->dev.of_node, "cle", &board->cle); > + > + if (of_property_read_u8(pdev->dev.of_node, "ale", &board->ale)) > board->ale = 1; > - if (!of_property_read_u32(pdev->dev.of_node, > - "bank-width", &val)) > - board->width = (u8)val * 8; > - else > + if (of_property_read_u8(pdev->dev.of_node, > + "bank-width", &board->width)) > board->width = 8; > - if (!of_property_read_u32(pdev->dev.of_node, > - "chip-delay", &val)) > - board->chip_delay = (u8)val; > + of_property_read_u8(pdev->dev.of_node, > + "chip-delay", &board->chip_delay); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/