Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754157AbbKWTfE (ORCPT ); Mon, 23 Nov 2015 14:35:04 -0500 Received: from mail-pa0-f51.google.com ([209.85.220.51]:33703 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753585AbbKWTfB (ORCPT ); Mon, 23 Nov 2015 14:35:01 -0500 Message-ID: <56536A62.4040103@linaro.org> Date: Mon, 23 Nov 2015 11:34:58 -0800 From: "Shi, Yang" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Z Lim , Will Deacon , Alexei Starovoitov , "David S. Miller" CC: daniel@iogearbox.net, Catalin Marinas , Xi Wang , LKML , Network Development , "linux-arm-kernel@lists.infradead.org" , linaro-kernel@lists.linaro.org Subject: Re: [PATCH 1/2] arm64: bpf: add 'store immediate' instruction References: <1447195301-16757-1-git-send-email-yang.shi@linaro.org> <1447195301-16757-2-git-send-email-yang.shi@linaro.org> <20151111121256.GI9562@arm.com> <20151111123955.GK9562@arm.com> <5644E97B.6050203@linaro.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1202 Lines: 38 Hi folks, Any more comments on this patch (store immediate only)? I need more time to add XADD (I'm supposed everyone agrees it is equivalent to atomic_add). However, this one is irrelevant to XADD, so we may be able to apply it first? Thanks, Yang On 11/12/2015 7:45 PM, Z Lim wrote: > On Thu, Nov 12, 2015 at 11:33 AM, Shi, Yang wrote: >> On 11/11/2015 4:39 AM, Will Deacon wrote: >>> >>> Wait a second, we're both talking rubbish here :) The STR (immediate) >>> form is referring to the addressing mode, whereas this patch wants to >>> store an immediate value to memory, which does need moving to a register >>> first. >> >> >> Yes, the immediate means immediate offset for addressing index. Doesn't mean >> to store immediate to memory. >> >> I don't think any load-store architecture has store immediate instruction. >> > > Indeed. Sorry for the noise. > > Somehow Will caught a whiff of whatever I was smoking then :) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/