Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753907AbbKWVQG (ORCPT ); Mon, 23 Nov 2015 16:16:06 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:60350 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751215AbbKWVQE (ORCPT ); Mon, 23 Nov 2015 16:16:04 -0500 Date: Mon, 23 Nov 2015 13:16:01 -0800 From: Stephen Boyd To: Russell King - ARM Linux Cc: linux-arm-kernel@lists.infradead.org, =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= , Arnd Bergmann , Nicolas Pitre , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Steven Rostedt Subject: Re: [RFC/PATCH 2/3] recordmcount: Record locations of __aeabi_{u}idiv() calls on ARM Message-ID: <20151123211601.GE19156@codeaurora.org> References: <1448068997-26631-1-git-send-email-sboyd@codeaurora.org> <1448068997-26631-3-git-send-email-sboyd@codeaurora.org> <20151121101349.GI8644@n2100.arm.linux.org.uk> <20151123205335.GD19156@codeaurora.org> <20151123210347.GW8644@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151123210347.GW8644@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4068 Lines: 99 On 11/23, Russell King - ARM Linux wrote: > On Mon, Nov 23, 2015 at 12:53:35PM -0800, Stephen Boyd wrote: > > On 11/21, Russell King - ARM Linux wrote: > > > On Fri, Nov 20, 2015 at 05:23:16PM -0800, Stephen Boyd wrote: > > > > @@ -452,14 +631,14 @@ static char const * > > > > __has_rel_mcount(Elf_Shdr const *const relhdr, /* is SHT_REL or SHT_RELA */ > > > > Elf_Shdr const *const shdr0, > > > > char const *const shstrtab, > > > > - char const *const fname) > > > > + char const *const fname, const char *find) > > > > { > > > > /* .sh_info depends on .sh_type == SHT_REL[,A] */ > > > > Elf_Shdr const *const txthdr = &shdr0[w(relhdr->sh_info)]; > > > > char const *const txtname = &shstrtab[w(txthdr->sh_name)]; > > > > > > > > - if (strcmp("__mcount_loc", txtname) == 0) { > > > > - fprintf(stderr, "warning: __mcount_loc already exists: %s\n", > > > > + if (strcmp(find, txtname) == 0) { > > > > + fprintf(stderr, "warning: %s already exists: %s\n", find, > > > > > > Oh, it's this which has been spewing that silly > > > "warning: __mcount_loc already exists" > > > > > > message thousands of times in my nightly kernel builds (so much so, that > > > I've had to filter the thing out of the logs.) Given that this is soo > > > noisy, I think first we need to get to the bottom of why this program is > > > soo noisy before we try to make it more functional. > > > > > > > This comment in recordmcount.pl may tell us something. > > > > # > > # Somehow the make process can execute this script on an > > # object twice. If it does, we would duplicate the mcount > > # section and it will cause the function tracer self test > > # to fail. Check if the mcount section exists, and if it does, > > # warn and exit. > > # > > print STDERR "ERROR: $mcount_section already in $inputfile\n" . > > "\tThis may be an indication that your build is corrupted.\n" . > > "\tDelete $inputfile and try again. If the same object file\n" . > > "\tstill causes an issue, then disable CONFIG_DYNAMIC_FTRACE.\n"; > > exit(-1); > > > > I don't think there's much that can be done here besides making > > it silent unless there's some verbose build flag set (-v?), but > > it is interesting that you see it spew thousands of times. I've > > never seen the error printed, but perhaps I'm not building the > > kernel the same way you are. Care to share how you're building > > and seeing these error messages? > > All I get is this: > > warning: __mcount_loc already exists: arch/arm/mm/mmap.o > > Not the "ERROR: ... already in ..." that the above would give. That's because I copied from the perl version of recordmcount. The C version of this tool doesn't have that nice comment. > > Nothing special. It's a seeded allyesconfig built with: > > $ make -k -j2 zImage modules dtbs LOADADDR=0x60008000 CONFIG_DEBUG_SECTION_MISMATCH=y O=/path/to/build/dir > > The seed being: > > CONFIG_MODULES=y > # CONFIG_LOCALVERSION_AUTO is not set > CONFIG_LOG_BUF_SHIFT=19 > CONFIG_ZBOOT_ROM_TEXT=0x70000000 > CONFIG_ZBOOT_ROM_BSS=0x61000000 > CONFIG_CMDLINE="root=/dev/mmcblk0p1 rootdelay=2 ro" > CONFIG_ARCH_VEXPRESS=y > # Must not have XIP support enabled > CONFIG_XIP_KERNEL=n > # Our toolchain has no T2 support > CONFIG_THUMB2_KERNEL=n > # Disable samples - this needs linux/seccomp.h in our host environment > CONFIG_SAMPLES=n > # Disable debug info (stop the kernel getting too large) > CONFIG_DEBUG_INFO=n > # 30 Dec 2013: disable building wanxl firmware: we don't have as68k etc > CONFIG_WANXL_BUILD_FIRMWARE=n > # 14 Jan 2015: disable GCOV > CONFIG_GCOV_KERNEL=n > Thanks. I don't see the prints on my system even with this config on top of allyesconfig. Odd. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/