Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754670AbbKWVQ4 (ORCPT ); Mon, 23 Nov 2015 16:16:56 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:60412 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753806AbbKWVQz (ORCPT ); Mon, 23 Nov 2015 16:16:55 -0500 Date: Mon, 23 Nov 2015 13:16:53 -0800 From: Stephen Boyd To: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Nicolas Pitre , Arnd Bergmann , Steven Rostedt Subject: Re: [RFC/PATCH 3/3] ARM: Replace calls to __aeabi_{u}idiv with udiv/sdiv instructions Message-ID: <20151123211653.GF19156@codeaurora.org> References: <1448068997-26631-1-git-send-email-sboyd@codeaurora.org> <1448068997-26631-4-git-send-email-sboyd@codeaurora.org> <20151123204955.GC19156@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1814 Lines: 53 On 11/23, M?ns Rullg?rd wrote: > Stephen Boyd writes: > > > On 11/21, M?ns Rullg?rd wrote: > >> > >> These functions are rather similar. Perhaps they could be combined > >> somehow. > >> > > > > Yes. I have this patch on top, just haven't folded it in because > > it doesn't reduce the lines of code. > > I don't see any reason to split it anyhow. The end result isn't any > harder to understand than the intermediate. Yep. > > > ----8<---- > > From: Stephen Boyd > > Subject: [PATCH] consolidate with module code > > > > Signed-off-by: Stephen Boyd > > --- > > arch/arm/include/asm/setup.h | 3 +++ > > arch/arm/kernel/module.c | 16 +++++-------- > > arch/arm/kernel/setup.c | 54 +++++++++++++++++++++++++++----------------- > > 3 files changed, 42 insertions(+), 31 deletions(-) > > > > diff --git a/arch/arm/include/asm/setup.h b/arch/arm/include/asm/setup.h > > index e0adb9f1bf94..3f251cdb94ef 100644 > > --- a/arch/arm/include/asm/setup.h > > +++ b/arch/arm/include/asm/setup.h > > @@ -25,4 +25,7 @@ extern int arm_add_memory(u64 start, u64 size); > > extern void early_print(const char *str, ...); > > extern void dump_machine_table(void); > > > > +extern void patch_uidiv(void *addr, size_t size); > > +extern void patch_idiv(void *addr, size_t size); > > Why not call things sdiv and udiv like the actual instructions? > Sure. I'll fold this into v2. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/