Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754349AbbKWXZy (ORCPT ); Mon, 23 Nov 2015 18:25:54 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:34218 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753085AbbKWXZw (ORCPT ); Mon, 23 Nov 2015 18:25:52 -0500 Date: Mon, 23 Nov 2015 15:25:43 -0800 From: Eduardo Valentin To: Sudip Mukherjee Cc: Zhang Rui , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH] thermal: ti-soc-thermal: fix error check Message-ID: <20151123232542.GA6815@localhost.localdomain> References: <1448283281-21402-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448283281-21402-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1423 Lines: 38 On Mon, Nov 23, 2015 at 06:24:41PM +0530, Sudip Mukherjee wrote: > We were only checking if data is not NULL but > ti_bandgap_get_sensor_data() can return NULL or ERR_PTR. Do you have a fail case? Can you please send the logs too? > > Signed-off-by: Sudip Mukherjee > --- > drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c > index b213a12..d76bb7c 100644 > --- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c > +++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c > @@ -365,7 +365,7 @@ int ti_thermal_remove_sensor(struct ti_bandgap *bgp, int id) > > data = ti_bandgap_get_sensor_data(bgp, id); > > - if (data && data->ti_thermal) { > + if (!IS_ERR_OR_NULL(data) && data->ti_thermal) { I don t really see the need for this as we always ti_bandgap_set_sensor_data with a valid pointer, never with a ERR PTR. So, it would be either valid or NULL. > if (data->our_zone) > thermal_zone_device_unregister(data->ti_thermal); > else > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/