Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752627AbbKXBWB (ORCPT ); Mon, 23 Nov 2015 20:22:01 -0500 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:34529 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752211AbbKXBV6 (ORCPT ); Mon, 23 Nov 2015 20:21:58 -0500 Date: Tue, 24 Nov 2015 12:21:18 +1100 (AEDT) From: Finn Thain To: Ondrej Zary cc: Sam Creasey , Michael Schmitz , "James E.J. Bottomley" , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers In-Reply-To: <201511232355.04017.linux@rainbow-software.org> Message-ID: References: <20151118083455.331768508@telegraphics.com.au> <201511211401.39957.linux@rainbow-software.org> <201511232355.04017.linux@rainbow-software.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1282 Lines: 32 On Mon, 23 Nov 2015, Ondrej Zary wrote: > > PDMA seems to be broken in multiple ways. NCR5380_pread cannot process > less than 128 bytes. In fact, 53C400 datasheet says that it's HW > limitation: non-modulo-128-byte transfers should use PIO. > > Adding > transfersize = round_down(transfersize, 128); > to generic_NCR5380_dma_xfer_len() improves the situation a bit. > > After modprobe, some small reads (8, 4, 24 and 64 bytes) are done using > PIO, then eight 512-byte reads using PDMA and then it fails on a > 254-byte read. First 128 bytes are read using PDMA and the next PDMA > operation hangs waiting forever for the host buffer to be ready. > A 128-byte PDMA receive followed by 126-byte PDMA receive? I don't see how that is possible given round_down(126, 128) == 0. Was this the actual 'len' argument to NCR5380_pread() in g_NCR5380.c? BTW, I presume that FLAG_NO_DMA_FIXUPS was set (which is the case if you pass ncr_53c400=1 option with modprobe). Otherwise you could see PDMA IO sizes like 127 etc. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/