Date: Tue, 24 Nov 2015 14:15:47 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
CC: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
        Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org,
        Andi Kleen <andi@firstfloor.org>, David Ahern <dsahern@gmail.com>,
        Kan Liang <kan.liang@intel.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH 31/37] perf callchain: Add count fields to struct
 callchain_node
Message-ID: <20151124051547.GA2636@sejong>
References: <1447955603-24895-1-git-send-email-acme@kernel.org>
 <1447955603-24895-32-git-send-email-acme@kernel.org>
 <20151123143528.GC3587@lerouge>
MIME-Version: 1.0
In-Reply-To: <20151123143528.GC3587@lerouge>
User-Agent: Mutt/1.5.24 (2015-08-30)
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 961
Lines: 28

Hi Frederic,

On Mon, Nov 23, 2015 at 03:35:30PM +0100, Frederic Weisbecker wrote:
> Namhyung,
> 
> On Thu, Nov 19, 2015 at 02:53:17PM -0300, Arnaldo Carvalho de Melo wrote:
> > From: Namhyung Kim <namhyung@kernel.org>
> > 
> > It's to track the count of occurrences of the callchains.
> 
> Please explain why you do something like this in the changelog, even just a single
> line to tell which feature is going to use this and why.
> 
> No need to resend just for that, it's just for future patches.

OK, I'll keep in mind that.

This patch is a preparation for supporting different callchain value
output style.  Instead of current percent output, it could have period
or count with this change.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/