Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752249AbbKXGQt (ORCPT ); Tue, 24 Nov 2015 01:16:49 -0500 Received: from relmlor2.renesas.com ([210.160.252.172]:21884 "EHLO relmlie1.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751093AbbKXGQq convert rfc822-to-8bit (ORCPT ); Tue, 24 Nov 2015 01:16:46 -0500 X-IronPort-AV: E=Sophos;i="5.20,338,1444662000"; d="scan'208";a="199176823" From: Yoshihiro Shimoda To: "kishon@ti.com" CC: "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-sh@vger.kernel.org" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" Subject: RE: [PATCH v5 0/4] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver Thread-Topic: [PATCH v5 0/4] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver Thread-Index: AQHRCxVrepBAbyLwzkmVklkNpYkUJp6q6Afw Date: Tue, 24 Nov 2015 06:16:42 +0000 Message-ID: References: <1445331471-5028-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> In-Reply-To: <1445331471-5028-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yoshihiro.shimoda.uh@renesas.com; x-originating-ip: [211.11.155.144] x-microsoft-exchange-diagnostics: 1;SG2PR06MB0920;5:v2/ZCaMH6QFELuf1gTa+ZDHng69TC49njoHRu3nUdRecmDcmG61xN7P2Nw7bNn8BJU9jbPVsmHUejKbHC/7FIlSp4Wq8jHUXDev8MZodNHqBMNpPbGAVPzkC3PlVGlA/c2CpGdzZKENK7vO+aTH7sA==;24:3zo8pab4LAMc053YeCgy39/lgG0NFUsRidT7i/AI4riNja6VBeiCGrWq/iVH4HGikZrZl7yPk+ohnaNuh/arUsjS4AS5Okre/lCChziWhww=;20:XNm+iBpnSnzyGBUcDpSRK86/xK/UF3yt4H1qLTrp/ofaZjKn/UpRlbUpUWrxRq8RILrRg6Csf6ZCMn+87iUCpp4ZiGxD1uf/QjpXfx4xPGr4Bhy7UnsUrqrWdlNzk/t+IeruCYxw12kdGvUePL+0h+JjCSfMzxyexv0qOm7uVoQ= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SG2PR06MB0920; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001)(10201501046);SRVR:SG2PR06MB0920;BCL:0;PCL:0;RULEID:;SRVR:SG2PR06MB0920; x-forefront-prvs: 0770F75EA9 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(199003)(377454003)(189002)(2501003)(76176999)(86362001)(92566002)(2950100001)(50986999)(5004730100002)(87936001)(5002640100001)(66066001)(6116002)(2351001)(122556002)(2900100001)(77096005)(81156007)(40100003)(54356999)(19580395003)(5003600100002)(5008740100001)(3846002)(10400500002)(106116001)(105586002)(586003)(76576001)(102836003)(5007970100001)(11100500001)(5001960100002)(74316001)(33656002)(230783001)(106356001)(101416001)(110136002)(189998001)(97736004);DIR:OUT;SFP:1102;SCL:1;SRVR:SG2PR06MB0920;H:SG2PR06MB0919.apcprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2015 06:16:42.3694 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB0920 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2674 Lines: 66 Hi Kishon, > From: Yoshihiro Shimoda > Sent: Tuesday, October 20, 2015 5:58 PM > > This patch is based on the latest linux-phy / next branch. > (commit id = 0f8669e343982ac66f4420335777cb5456b8abb0) Would you review this patch set? I confirmed the patch set could apply the latest linux-phy / next branch correctly. (commit id = 8005c49d9aea74d382f474ce11afbbc7d7130bec) Best regards, Yoshihiro Shimoda > Changes from v4: > - Modify Kconfig to "depends on OF && ARCH_SHMOBILE". > - Modify Kconfig to "select GENERIC_PHY" instead of "depends on GENERIC_PHY". > - Modify device tree documentation about "reg" of example. > - Remove spinlock handling because phy-core driver calls mutex_lock(). > - Change valiable name to val instead of tmp. > - Remove dev_set_drvdata. > - Use dev_vdbg() instead of dev_dbg(). > - Change rcar_gen3_device_recognition()'s condition as one line. > - Remove unnecessary value in rcar_gen3_phy_usb2_probe(). > - Modify MAINTAINERS about this driver. > > Changes from v3: > - Shorten structure names to avoid new line if we add a long function name. > - Add ID/VBUS pin detection for peripheral mode. > > Changes from v2: > - Modify Kconfig to add "depends on OF" and "depends on ARCH_SHMOBILE". > - Add more information in the dt document. > - Change reg-names from "usb2" to "usb2_host". > > Changes from v1: > - Revise some typos. > - Remove using clk API to enable/disable the clocks. > (In other words, this driver expects to enable/disable the clocks by > Runtime PM API by the phy-core driver.) > - Remove an unnecessary header file (asm/cmpxchg.h). > > Yoshihiro Shimoda (4): > phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver > phy: rcar-gen3-usb2: change the mode to OTG on the combined channel > phy: rcar-gen3-usb2: add runtime ID/VBUS pin detection > MAINTAINERS: add Renesas usb2 phy driver > > .../devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 39 +++ > MAINTAINERS | 6 + > drivers/phy/Kconfig | 7 + > drivers/phy/Makefile | 1 + > drivers/phy/phy-rcar-gen3-usb2.c | 380 +++++++++++++++++++++ > 5 files changed, 433 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > create mode 100644 drivers/phy/phy-rcar-gen3-usb2.c > > -- > 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/