Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752660AbbKXGmx (ORCPT ); Tue, 24 Nov 2015 01:42:53 -0500 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:46803 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752051AbbKXGmv (ORCPT ); Tue, 24 Nov 2015 01:42:51 -0500 MIME-Version: 1.0 In-Reply-To: <20151124063808.GB32142@lukather> References: <20151123124356.GW32142@lukather> <20151124063808.GB32142@lukather> From: Chen-Yu Tsai Date: Tue, 24 Nov 2015 14:42:26 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/5] ARM: dts: sun8i: Add SID node To: Maxime Ripard Cc: Chen-Yu Tsai , Josef Gajdusek , linux-sunxi , linux-clk , linux-pm@vger.kernel.org, linux-kernel , linux-arm-kernel , devicetree , gpatchesrdh@mveas.com, Mike Turquette , Hans De Goede , Stephen Boyd , Michael Turquette , Emilio Lopez , Russell King - ARM Linux , Eduardo Valentin , Zhang Rui , Kumar Gala , Ian Campbell , Mark Rutland , Pawel Moll , Rob Herring Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1927 Lines: 59 On Tue, Nov 24, 2015 at 2:38 PM, Maxime Ripard wrote: > On Tue, Nov 24, 2015 at 11:13:13AM +0800, Chen-Yu Tsai wrote: >> Hi, >> >> On Mon, Nov 23, 2015 at 8:43 PM, Maxime Ripard >> wrote: >> > Hi, >> > >> > On Mon, Nov 23, 2015 at 09:02:48AM +0100, Josef Gajdusek wrote: >> >> Add a node describing the Security ID memory to the >> >> Allwinner H3 .dtsi file. >> >> >> >> Signed-off-by: Josef Gajdusek >> >> --- >> >> arch/arm/boot/dts/sun8i-h3.dtsi | 7 +++++++ >> >> 1 file changed, 7 insertions(+) >> >> >> >> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi >> >> index 0faa38a..58de718 100644 >> >> --- a/arch/arm/boot/dts/sun8i-h3.dtsi >> >> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi >> >> @@ -359,6 +359,13 @@ >> >> #size-cells = <0>; >> >> }; >> >> >> >> + sid: eeprom@01c14000 { >> >> + compatible = "allwinner,sun4i-a10-sid"; >> >> + reg = <0x01c14000 0x400>; >> > >> > The datasheet says it's 256 bytes wide, while the size here is of 1kB, >> > is it intentional? >> >> My H3 datasheet (v1.1) says its 1 kB wide. > > Is it? in the Security ID section, it is said to be 2kb == 256B wide. Right. I was looking at the memory map. Maybe it's sparsely mapped? I guess we'll know soon. ChenYu >> It'd be nice if Allwinner actually listed the "usable" E-fuse >> offsets and widths, instead of having us dig through the SDK code. > > Yep. > > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/