Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752786AbbKXHNk (ORCPT ); Tue, 24 Nov 2015 02:13:40 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:60925 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752326AbbKXHNj (ORCPT ); Tue, 24 Nov 2015 02:13:39 -0500 Date: Tue, 24 Nov 2015 08:13:33 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Guenter Roeck Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck , linux-kernel@vger.kernel.org, Timo Kokkonen , linux-doc@vger.kernel.org, Jonathan Corbet Subject: Re: [PATCH v5 5/8] watchdog: Simplify update_worker Message-ID: <20151124071333.GE19888@pengutronix.de> References: <1448248865-21684-1-git-send-email-linux@roeck-us.net> <1448248865-21684-6-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1448248865-21684-6-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 751 Lines: 22 Hello, On Sun, Nov 22, 2015 at 07:21:02PM -0800, Guenter Roeck wrote: > Drop 'cancel' parameter; simply cancel worker unconditionally > if not needed. > > Signed-off-by: Guenter Roeck This is a good change, but given that watchdog_update_worker is introduced in this series it should be squashed accordingly. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/