Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752884AbbKXHgn (ORCPT ); Tue, 24 Nov 2015 02:36:43 -0500 Received: from mail.skyhub.de ([78.46.96.112]:36167 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752321AbbKXHgl (ORCPT ); Tue, 24 Nov 2015 02:36:41 -0500 Date: Tue, 24 Nov 2015 08:36:39 +0100 From: Borislav Petkov To: "Luck, Tony" Cc: "Chen, Gong" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool. Message-ID: <20151124073639.GA3785@pd.tnic> References: <20151111193845.GA9055@agluck-desk.sc.intel.com> <3165a4989dcb45fc0306438d40d0cf2ace429c4c.1447280215.git.tony.luck@intel.com> <20151121191556.GB15172@pd.tnic> <3908561D78D1C84285E8C5FCA982C28F39E9FEF6@ORSMSX114.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F39E9FEF6@ORSMSX114.amr.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1517 Lines: 41 On Tue, Nov 24, 2015 at 12:19:18AM +0000, Luck, Tony wrote: > > Also, two more fixes I've done while injecting in a kvm guest I'm > > sending as a reply to this message. Will inject on a real box too. > > Ok ... applied those two on top of my "UNTESTED" patch and injected an error to force a UCNA log. Ok, what error type is that in EINJ nomenclature? I had only /sys/kernel/debug/apei/einj/available_error_type:0x00000002 Processor Uncorrectable non-fatal /sys/kernel/debug/apei/einj/available_error_type:0x00000008 Memory Correctable /sys/kernel/debug/apei/einj/available_error_type:0x00000010 Memory Uncorrectable non-fatal and I would've guessed it is the 0x10 type, i.e., the memory uncorrectable which is non-fatal - assuming here - but that one got promoted to a #MC on my box. The processor uncorrectable didn't want to inject due to missing EINJ instruction 0x5 or so... > Everything looked ok. Just one copy on the console and in > /var/log/mcelog (actually logs from bank7 and bank3 ... but that was > expected from this test). Good. > So my patch is tested, and take this > > Acked-by: Tony Luck for your two additional patches. Thanks! -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/