Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752794AbbKXIHh (ORCPT ); Tue, 24 Nov 2015 03:07:37 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:34148 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751656AbbKXIHf (ORCPT ); Tue, 24 Nov 2015 03:07:35 -0500 Message-ID: <1448352450.19513.53.camel@collabora.co.uk> Subject: Re: [PATCH] modpost: don't add a trailing wildcard for OF module aliases From: Sjoerd Simons To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: devicetree@vger.kernel.org, Rob Herring , Jean Delvare , Mark Brown , Brian Norris , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org Date: Tue, 24 Nov 2015 09:07:30 +0100 In-Reply-To: <1447943308-27689-1-git-send-email-javier@osg.samsung.com> References: <1447943308-27689-1-git-send-email-javier@osg.samsung.com> Organization: Collabora Ltd. Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.2-1 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tAO87gHX019083 Content-Length: 1292 Lines: 34 On Thu, 2015-11-19 at 11:28 -0300, Javier Martinez Canillas wrote: >  scripts/mod/file2alias.c | 3 +-- >  1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c > index 5b96206e9aab..65eaab8b7798 100644 > --- a/scripts/mod/file2alias.c > +++ b/scripts/mod/file2alias.c > @@ -125,7 +125,7 @@ do > {                                                            \ >                  sprintf(str + strlen(str), "*");                \ >  } while(0) >   > -/* Always end in a wildcard, for future extension */ > +/* End in a wildcard, for future extension */ >  static inline void add_wildcard(char *str) >  { >   int len = strlen(str); > @@ -704,7 +704,6 @@ static int do_of_entry (const char *filename, > void *symval, char *alias) >   if (isspace (*tmp)) >   *tmp = '_'; >   > - add_wildcard(alias); >   return 1; >  } >  ADD_TO_DEVTABLE("of", of_device_id, do_of_entry); Reviewed-by: Sjoerd Simons -- Sjoerd Simons Collabora Ltd. ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?