Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753215AbbKXItx (ORCPT ); Tue, 24 Nov 2015 03:49:53 -0500 Received: from mx2.suse.de ([195.135.220.15]:59501 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752279AbbKXItw (ORCPT ); Tue, 24 Nov 2015 03:49:52 -0500 Subject: Re: [PATCH] mm/compaction: __compact_pgdat() code cleanuup To: Joonsoo Kim , Andrew Morton References: <1448346282-5435-1-git-send-email-iamjoonsoo.kim@lge.com> Cc: Mel Gorman , Yaowei Bai , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Joonsoo Kim From: Vlastimil Babka Message-ID: <565424AD.7030808@suse.cz> Date: Tue, 24 Nov 2015 09:49:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1448346282-5435-1-git-send-email-iamjoonsoo.kim@lge.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1568 Lines: 51 On 11/24/2015 07:24 AM, Joonsoo Kim wrote: > This patch uses is_via_compact_memory() to distinguish direct compaction. > And it also reduces indentation on compaction_defer_reset > by filtering failure case. There is no functional change. > > Signed-off-by: Joonsoo Kim > --- > mm/compaction.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index de3e1e7..2b1a15e 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1658,14 +1658,17 @@ static void __compact_pgdat(pg_data_t *pgdat, struct compact_control *cc) > !compaction_deferred(zone, cc->order)) > compact_zone(zone, cc); > > - if (cc->order > 0) { > - if (zone_watermark_ok(zone, cc->order, > - low_wmark_pages(zone), 0, 0)) > - compaction_defer_reset(zone, cc->order, false); > - } > - > VM_BUG_ON(!list_empty(&cc->freepages)); > VM_BUG_ON(!list_empty(&cc->migratepages)); > + > + if (is_via_compact_memory(cc->order)) > + continue; That's fine. > + if (!zone_watermark_ok(zone, cc->order, > + low_wmark_pages(zone), 0, 0)) > + continue; > + > + compaction_defer_reset(zone, cc->order, false); Here I'd personally find the way of "if(watermark_ok) defer_reset()" logic easier to follow. > } > } > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/