Date: Tue, 24 Nov 2015 17:02:58 +0800
From: Shengjiu Wang <shengjiu.wang@freescale.com>
To: Nicolin Chen <nicoleotsuka@gmail.com>
CC: <robh+dt@kernel.org>, <pawel.moll@arm.com>, <mark.rutland@arm.com>,
        <ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
        <timur@tabi.org>, <Xiubo.Lee@gmail.com>, <lgirdwood@gmail.com>,
        <broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
        <shawnguo@kernel.org>, <alsa-devel@alsa-project.org>,
        <linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
Subject: Re: [PATCH V3 1/3] ASoC: fsl_esai: spba clock is needed by esai
 device
Message-ID: <20151124090256.GA17516@shlinux2>
References: <cover.1448348336.git.shengjiu.wang@freescale.com>
 <37808c01df126622c41c2d413fddf838dc2aa71d.1448348336.git.shengjiu.wang@freescale.com>
 <20151124083344.GA14109@Asurada-CZ80>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20151124083344.GA14109@Asurada-CZ80>
User-Agent: Mutt/1.5.21 (2010-09-15)
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2015 09:06:05.1894
 (UTC)
X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB1230
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2180
Lines: 47

On Tue, Nov 24, 2015 at 12:33:45AM -0800, Nicolin Chen wrote:
> On Tue, Nov 24, 2015 at 03:03:28PM +0800, Shengjiu Wang wrote:
> 
> > @@ -469,6 +471,9 @@ static int fsl_esai_startup(struct snd_pcm_substream *substream,
> >  	ret = clk_prepare_enable(esai_priv->coreclk);
> >  	if (ret)
> >  		return ret;
> > +	ret = clk_prepare_enable(esai_priv->spbaclk);
> > +	if (ret)
> > +		goto err_spbaclk;
> >  	if (!IS_ERR(esai_priv->extalclk)) {
> >  		ret = clk_prepare_enable(esai_priv->extalclk);
> >  		if (ret)
> 
> Just like for extalclk there is a IS_ERR check out there, there
> should be one for spbaclk as well. Otherwise....
> 
> root@imx6qdlsolo:~# aplay /unit_tests/audio8k16S.wav 
> [   29.956250] Unable to handle kernel paging request at virtual address fffffffe
> [   29.963491] pgd = edd98000
> [   29.966278] [fffffffe] *pgd=afffd861, *pte=00000000, *ppte=00000000
> [   29.972615] Internal error: Oops: 37 [#1] SMP ARM
> [   29.977327] Modules linked in:
> [   29.980410] CPU: 0 PID: 755 Comm: aplay Not tainted 4.4.0-rc1-12414-gcc8db17 #250
> [   29.987899] Hardware name: Freescale i.MX6 SoloX (Device Tree)
> [   29.993738] task: edece780 ti: ed26a000 task.ti: ed26a000
> [   29.999156] PC is at clk_prepare+0x18/0x38
> [   30.003268] LR is at mark_held_locks+0x70/0x98
> [   30.007720] pc : [<c0568714>]    lr : [<c006f42c>]    psr: 600f0013
> [   30.007720] sp : ed26bc60  ip : 00000003  fp : ed26bc74
> [   30.019204] r10: eebe4d9c  r9 : eeb2e00c  r8 : eeb2e00c
> [   30.024435] r7 : fffffffe  r6 : eeb2c500  r5 : eeb2d0c0  r4 : fffffffe
> [   30.030966] r3 : edece780  r2 : 00000001  r1 : 00000001  r0 : 00000001
> [   30.037502] Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment none
> [   30.044643] Control: 10c5387d  Table: add9804a  DAC: 00000051
> [   30.050395] Process aplay (pid: 755, stack limit = 0xed26a210)
>

Will fix it in next version, and send it out later.

best regards
wang shengjiu 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/