Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753511AbbKXJWd (ORCPT ); Tue, 24 Nov 2015 04:22:33 -0500 Received: from mail-pa0-f49.google.com ([209.85.220.49]:33016 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752861AbbKXJW2 (ORCPT ); Tue, 24 Nov 2015 04:22:28 -0500 Date: Tue, 24 Nov 2015 18:23:26 +0900 From: Sergey Senozhatsky To: "Kirill A. Shutemov" Cc: Sergey Senozhatsky , Vladimir Davydov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -mm v2] mm: add page_check_address_transhuge helper Message-ID: <20151124092326.GC1254@swordfish> References: <1448011913-12121-1-git-send-email-vdavydov@virtuozzo.com> <20151124042941.GE705@swordfish> <20151124090930.GB15712@node.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151124090930.GB15712@node.shutemov.name> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1388 Lines: 46 On (11/24/15 11:09), Kirill A. Shutemov wrote: [..] > diff --git a/mm/page_idle.c b/mm/page_idle.c > index 374931f32ebc..4ea9c4ef5146 100644 > --- a/mm/page_idle.c > +++ b/mm/page_idle.c > @@ -66,8 +66,12 @@ static int page_idle_clear_pte_refs_one(struct page *page, > if (pte) { > referenced = ptep_clear_young_notify(vma, addr, pte); > pte_unmap(pte); > - } else > + } else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) { > referenced = pmdp_clear_young_notify(vma, addr, pmd); > + } else { > + /* unexpected pmd-mapped page? */ > + WARN_ON_ONCE(1); > + } > > spin_unlock(ptl); > > diff --git a/mm/rmap.c b/mm/rmap.c > index 27916086ac50..499b24511b1f 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -929,9 +929,12 @@ static int page_referenced_one(struct page *page, struct vm_area_struct *vma, > referenced++; > } > pte_unmap(pte); > - } else { > + } else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) { > if (pmdp_clear_flush_young_notify(vma, address, pmd)) > referenced++; > + } else { > + /* unexpected pmd-mapped page? */ > + WARN_ON_ONCE(1); > } > spin_unlock(ptl); yes, works for me. -ss -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/