Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754374AbbKXKbD (ORCPT ); Tue, 24 Nov 2015 05:31:03 -0500 Received: from helcar.hengli.com.au ([209.40.204.226]:36336 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754026AbbKXKa6 (ORCPT ); Tue, 24 Nov 2015 05:30:58 -0500 Date: Tue, 24 Nov 2015 18:30:33 +0800 From: Herbert Xu To: Tom Herbert , netdev@vger.kernel.org, davem@davemloft.net, Sowmini Varadhan , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [RFC PATCH 1/2] Crypto support aesni rfc5288 Message-ID: <20151124103033.GA623@gondor.apana.org.au> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 970 Lines: 24 On Mon, Nov 23, 2015 at 09:42:44AM -0800, Dave Watson wrote: > Support rfc5288 using intel aesni routines. See also rfc5246. > > AAD length is 13 bytes padded out to 16. Padding bytes have to be > passed in in scatterlist currently, which probably isn't quite the > right fix. > > The assoclen checks were moved to the individual rfc stubs, and the > common routines support all assoc lengths. I know this is just an RFC. But if we were going to add an rfc5288 template then you should add a C version first, then followed by the aesni optimised version. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/