Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753976AbbKXK4B (ORCPT ); Tue, 24 Nov 2015 05:56:01 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:33939 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752563AbbKXKz7 (ORCPT ); Tue, 24 Nov 2015 05:55:59 -0500 Date: Tue, 24 Nov 2015 10:55:56 +0000 From: Matt Fleming To: Ingo Molnar Cc: Thomas Gleixner , "H . Peter Anvin" , Toshi Kani , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, Borislav Petkov , Sai Praneeth Prakhya , stable@vger.kernel.org, Dave Hansen Subject: Re: [PATCH 1/6] x86/efi: PFN_ALIGN() _text and _end when calculating number of pages Message-ID: <20151124105556.GA2460@codeblueprint.co.uk> References: <1448285594-17617-1-git-send-email-matt@codeblueprint.co.uk> <1448285594-17617-2-git-send-email-matt@codeblueprint.co.uk> <20151124082323.GA23451@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151124082323.GA23451@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1216 Lines: 26 On Tue, 24 Nov, at 09:23:23AM, Ingo Molnar wrote: > > Didn't we want to do the _end alignment linker script fix instead? I think we should do both. This patch is tagged for stable because it fixes a bug in the existing code. It's obvious and it's explicit and it's much easier to know when someone might want to backport it. Changing the linker script which indirectly fixes the above bug is a much more subtle solution, with much larger potential for fallout because it affects multiple chunks of kernel code. > Alignment assumptions are easy to make when symbols are well aligned typically (as > in this case), so we should guarantee the alignment property instead of > complicating the code. I don't agree that sprinkling PFN_ALIGN() complicates the code, it's a minimal change with a well known kernel idiom. But yes, aligning these symbols in the linker script is generally a good idea. The two patches are worthwhile, for different reasons; let's do both. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/