Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753520AbbKXNMS (ORCPT ); Tue, 24 Nov 2015 08:12:18 -0500 Received: from eusmtp01.atmel.com ([212.144.249.243]:28388 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752263AbbKXNMQ (ORCPT ); Tue, 24 Nov 2015 08:12:16 -0500 Date: Tue, 24 Nov 2015 14:12:13 +0100 From: Ludovic Desroches To: Ulf Hansson CC: Nicolas Ferre , Alexandre Belloni , linux-mmc , "linux-kernel@vger.kernel.org" , Jean-Christophe Plagniol-Villard , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power Message-ID: <20151124131213.GB2228@odux.rfo.atmel.com> Mail-Followup-To: Ulf Hansson , Nicolas Ferre , Alexandre Belloni , linux-mmc , "linux-kernel@vger.kernel.org" , Jean-Christophe Plagniol-Villard , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" References: <1446825570-30029-1-git-send-email-ludovic.desroches@atmel.com> <1446825570-30029-2-git-send-email-ludovic.desroches@atmel.com> <20151109132305.GC15706@odux.rfo.atmel.com> <20151109144030.GD15706@odux.rfo.atmel.com> <20151109163026.GE15706@odux.rfo.atmel.com> <20151124092341.GA2228@odux.rfo.atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1644 Lines: 42 On Tue, Nov 24, 2015 at 12:01:53PM +0100, Ulf Hansson wrote: > On 24 November 2015 at 10:23, Ludovic Desroches > wrote: > > Hi Ulf, > > > > On Mon, Nov 09, 2015 at 05:30:26PM +0100, Ludovic Desroches wrote: > >> On Mon, Nov 09, 2015 at 05:00:46PM +0100, Ulf Hansson wrote: > > > > [...] > > > >> > Now, this discussion was interesting, but I forgot what problem you > >> > actually where trying to solve? :-) > >> > >> There is this discussion because of two things: > >> - Fixing something I consider as a bug: when I have a VMMC, only > >> setting/clearing bit 0. Our controller strictly obeys to the spec and > >> check the 'SD Bus Voltage Select' field. Since we put a reserved value > >> (000), the Power On is not performed. > >> - I was trying to get help to understand what is this 'SD Bus Voltage'. > >> For our controller and sdhci_set_power(), it seems to stand for VMMC. > >> For me, everything concerning bus voltage is related to VQMMC, so I was > >> disappointed. > > > > Do you plan to take the patch for VMMC? If yes, I will send a new patch > > for the device tree (I'll only add vmmc, not vqmmc as discussed); if > > not, forget these two patches. > > > > Which patch do you refer to for "VMMC"? > This one to not write an invalid voltage in the power control register even if we have an external regulator for vmmc. Regards Ludovic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/