Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753606AbbKXNMZ (ORCPT ); Tue, 24 Nov 2015 08:12:25 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:34202 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752263AbbKXNMX (ORCPT ); Tue, 24 Nov 2015 08:12:23 -0500 Date: Tue, 24 Nov 2015 14:12:18 +0100 From: LABBE Corentin To: Josh Wu Cc: computersforpeace@gmail.com, dwmw2@infradead.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH v2 2/2] mtd: nand: atmel_nand: fix a possible NULL dereference Message-ID: <20151124131218.GA7545@Red> References: <1448005517-26004-1-git-send-email-clabbe.montjoie@gmail.com> <1448005517-26004-3-git-send-email-clabbe.montjoie@gmail.com> <564EDACA.30204@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <564EDACA.30204@atmel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1486 Lines: 43 On Fri, Nov 20, 2015 at 04:33:14PM +0800, Josh Wu wrote: > Hi, Corentin > > Thanks for the patch. It looks fine to me, just one nitpick in below: > > On 11/20/2015 3:45 PM, LABBE Corentin wrote: > > of_match_device could return NULL, and so cause a NULL pointer > > dereference later. > > > > Signed-off-by: LABBE Corentin > > --- > > drivers/mtd/nand/atmel_nand.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c > > index 475c938..7902967 100644 > > --- a/drivers/mtd/nand/atmel_nand.c > > +++ b/drivers/mtd/nand/atmel_nand.c > > @@ -1496,8 +1496,9 @@ static int atmel_of_init_port(struct atmel_nand_host *host, > > struct atmel_nand_data *board = &host->board; > > enum of_gpio_flags flags = 0; > > > > - host->caps = (struct atmel_nand_caps *) > > - of_match_device(atmel_nand_dt_ids, host->dev)->data; > > + host->caps = of_device_get_match_data(host->dev); > > + if (!host->caps) > > + return 1; > > it's better to use -EINVAL here. > Hello I do that Uwe Kleine-K?nig said to me to do in others thread: https://lkml.org/lkml/2015/11/12/70 and https://lkml.org/lkml/2015/11/16/211 Regards -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/