Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753587AbbKXNp6 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 24 Nov 2015 08:45:58 -0500
Received: from mout.kundenserver.de ([212.227.126.130]:62655 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751003AbbKXNp4 convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 24 Nov 2015 08:45:56 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: =?ISO-8859-1?Q?M=E5ns_Rullg=E5rd?= <mans@mansr.com>,
        Nicolas Pitre <nicolas.pitre@linaro.org>,
        Peter Maydell <peter.maydell@linaro.org>,
        Russell King - ARM Linux <linux@arm.linux.org.uk>,
        "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Stephen Boyd <sboyd@codeaurora.org>,
        lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Christopher Covington <cov@codeaurora.org>,
        Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Subject: Re: [RFC/PATCH 0/3] ARM: Use udiv/sdiv for __aeabi_{u}idiv library functions
Date: Tue, 24 Nov 2015 14:45:16 +0100
Message-ID: <2604538.XjBEKvm9od@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <yw1xoaejr3u6.fsf@unicorn.mansr.com>
References: <1448068997-26631-1-git-send-email-sboyd@codeaurora.org> <3811106.btnGdZynet@wuerfel> <yw1xoaejr3u6.fsf@unicorn.mansr.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
Content-Type: text/plain; charset="iso-8859-1"
X-Provags-ID: V03:K0:ROaC64BEe0XzgtOpaphNYfuYrg+77tW64RVWK0N2fJ+QsfSZweX
 rI2MHM6kA5of0gNgkkCsY67zqyt0OyKJYVX/6gUUB1+R0WGpa58VsMp/LS3gtqbLCj3WuwY
 +uRXeRthZbni3/ABVjm8OJMVZPrxOfDDasGMNc0I7GVCDl90IP7rPptkjoytfSbxIvSIViK
 r3EHXWhE6zTRKZKqTvcMg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:o8kT9/wuY+M=:TovvONmWl5kGQiwdeRTnDd
 XefiVkAWfRbhb8o1qMX1AFJpNJvdQmirxTaG1G1ZI/hg7dRwfRfxKNFsmeF2aIKgsh7HufQcW
 VtOnhxMpTMGhh0fMyL4+ZqPnS9wDOAQ/u233p1iAJn8yUokb6nzbilk/FT6hnFjRSEqRJmIfp
 Iid41MennzJ4Nu/Or/j2jfaloXRSMW1+DEmKOseIAIeqkihiq+fB232r0dm/8QTXW6QZvOUWR
 00QtCLPwkzAzx5doclrDAM3Lqf9bCpz+sA20m1gk1P4R5ZTzY5TXPcwtEhJi6sCtm4V78xt1Q
 pkVFj47Ym798q6mSrA5I6gkq4vFo7N8UkdwCRN8YsQPgrk9Fsn74pZQpIgLN/cuOnyg82+PuO
 ungjfAsaIAoKNcXDrXUUxfS2HvcEhFoYkfPzNoketn+aH5eYqPB6geTyo+V67W+qtZ43LJzV2
 eXKdOaYbwWtnkXJfckybCcyw8yRq59yLNZfVYhzfS3GyHy94SV56jxe5A2xfXodrQN4Oq6Dqk
 7phC+YesRmcq7iHT2ncGX4TRhP+TksZ1cjipqGXAO8vuW7cdPegt6LGQTfXs3RlKiJt/adlM0
 sUrD3MGHuCJE6jF/k5vhCBa+pL4VGKbDiaNv/wpKXTBry6lVDiH0Hmp22v2rIqtCFUoinsl0U
 +UtQfpqyn0btalGHgRy88+fV3KqX+Ybjg3IvGsqe0V0ZzyZmeXGZk2bomnHRUvOwc5gPfbNwE
 zPm4ri4Zt2gblhZI
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2067
Lines: 58

On Tuesday 24 November 2015 12:15:13 M?ns Rullg?rd wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
> > On Monday 23 November 2015 15:13:52 Stephen Boyd wrote:
> >> On 11/23, Arnd Bergmann wrote:
> >> > On Monday 23 November 2015 13:32:06 Stephen Boyd wrote:
> >> > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> >> > index b251013eef0a..bad6343c34d5 100644
> >> Do you have the information on these custom opcodes? I can work
> >> that into the patches assuming the MIDR is different.
> >
> > Thomas Petazzoni said this in a private mail:
> >
> > | According to the datasheet, the PJ4B has integer signed and unsigned
> > | divide, similar to the sdiv and udiv ARM instructions. But the way to
> > | access it is by doing a MRC instruction.
> > |
> > |    MRC<cond> p6, 1, Rd , CRn , CRm, 4
> > |
> > |for PJ4B is the same as:
> > |
> > |    SDIV Rd , Rn, Rm
> > |
> > | on ARM cores.
> > |
> > |And:
> > |
> > |    MRC<cond> p6, 1, Rd , CRn , CRm, 0
> > |
> > |for PJ4B is the same as:
> > |
> > |    UDIV Rd , Rn, Rm
> > |
> > |on ARM cores.
> > |
> > |This is documented in the "Extended instructions" section of the
> > |PJ4B datasheet.
> >
> > I assume what he meant was that this is true for both PJ4 and PJ4B
> > but not for PJ4B-MP, which has the normal udiv/sdiv instructions.
> >
> > IOW, anything with CPU implementer 0x56 part 0x581 should use those,
> > while part 0x584 can use the sdiv/udiv that it reports correctly.
> 
> Or we could simply ignore those and they'd be no worse off than they are
> now.

Well, if we add all the infrastructure to do dynamic patching, we
might as well use it here, that is a very little extra effort.

I'm not convinced that the dynamic patching for idiv is actually needed
but I'm not objecting either, and Stephen has done the work already.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/