Date: Tue, 24 Nov 2015 10:53:33 -0500 (EST)
From: Alan Stern <stern@rowland.harvard.edu>
To: Peter Chen <peter.chen@freescale.com>
cc: Marek Szyprowski <m.szyprowski@samsung.com>, <linux-usb@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Ruslan Bilovol <ruslan.bilovol@gmail.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v7 4/4] usb: gadget: udc-core: independent registration
 of gadgets and gadget drivers
In-Reply-To: <20151124022449.GA25698@shlinux2>
Message-ID: <Pine.LNX.4.44L0.1511241027200.1803-100000@iolanthe.rowland.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2045
Lines: 59

On Tue, 24 Nov 2015, Peter Chen wrote:

> > > @@ -403,6 +408,18 @@ int usb_add_gadget_udc_release(struct device *parent, struct usb_gadget *gadget,
> > >  	usb_gadget_set_state(gadget, USB_STATE_NOTATTACHED);
> > >  	udc->vbus = true;
> > >  
> > > +	/* pick up one of pending gadget drivers */
> > > +	list_for_each_entry(driver, &gadget_driver_pending_list, pending) {
> > > +		if (!driver->udc_name || strcmp(driver->udc_name,
> > > +						dev_name(&udc->dev)) == 0) {
> > > +			ret = udc_bind_to_driver(udc, driver);
> > > +			if (ret)
> > > +				goto err4;
> > > +			list_del(&driver->pending);
> > 
> > This has to be list_del_init().  And somewhere in
> > usb_gadget_probe_driver() you need to do
> > INIT_LIST_HEAD(&driver->pending).
> > 
> > > @@ -577,6 +596,10 @@ int usb_gadget_unregister_driver(struct usb_gadget_driver *driver)
> > >  			break;
> > >  		}
> > >  
> > > +	if (ret) {
> > > +		list_del(&driver->pending);
> > 
> > Otherwise this will cause a crash or corrupt some random area of 
> > memory.
> > 
> 
> Alan, would you please explain more what use case will cause memory
> corruption for above code?

On Tue, 24 Nov 2015, Marek Szyprowski wrote:

> 'pending' handle is added to gadget_driver_pending_list in
> usb_gadget_probe_driver(),
> then when udc is available it is removed from this list and bound to the
> given driver.
> In usb_gadget_unregister_driver() the gadget is either unbound from the
> udc or if is
> was not bound to any udc, removed from pending list. I see no need for
> adding
> INIT_LIST_HEAD.

I'm sorry, you guys are right.  I didn't notice the "if (ret) {" line
added to usb_gadget_unregister_driver().  That line insures that we
don't try to remove the driver from the pending list unless it really
is on the list.

So never mind...

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/