Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753415AbbKXQDa (ORCPT ); Tue, 24 Nov 2015 11:03:30 -0500 Received: from mail-pa0-f66.google.com ([209.85.220.66]:35783 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797AbbKXQD2 (ORCPT ); Tue, 24 Nov 2015 11:03:28 -0500 From: Wenwei Tao To: mb@lightnvm.io Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: [PATCH] lightnvm: remove targets when corresponding nvm device exit Date: Wed, 25 Nov 2015 00:03:08 +0800 Message-Id: <1448380988-3988-1-git-send-email-ww.tao0320@gmail.com> X-Mailer: git-send-email 2.5.1.windows.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1633 Lines: 54 the target should be unreachable when underlying device was gone. Signed-off-by: Wenwei Tao --- drivers/lightnvm/core.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index f659e60..b95c6c4 100644 --- a/drivers/lightnvm/core.c +++ b/drivers/lightnvm/core.c @@ -278,10 +278,18 @@ err: return ret; } +static void nvm_remove_target(struct nvm_target *t); + static void nvm_exit(struct nvm_dev *dev) { + struct nvm_target *t, *n; + if (dev->ppalist_pool) dev->ops->destroy_dma_pool(dev->ppalist_pool); + down_write(&nvm_lock); + list_for_each_entry_safe(t, n, &dev->online_targets, list) + nvm_remove_target(t); + up_write(&nvm_lock); nvm_free(dev); pr_info("nvm: successfully unloaded\n"); @@ -496,13 +504,13 @@ static int __nvm_configure_create(struct nvm_ioctl_create *create) static int __nvm_configure_remove(struct nvm_ioctl_remove *remove) { - struct nvm_target *t = NULL; + struct nvm_target *n, *t = NULL; struct nvm_dev *dev; int ret = -1; down_write(&nvm_lock); list_for_each_entry(dev, &nvm_devices, devices) - list_for_each_entry(t, &dev->online_targets, list) { + list_for_each_entry_safe(t, n, &dev->online_targets, list) { if (!strcmp(remove->tgtname, t->disk->disk_name)) { nvm_remove_target(t); ret = 0; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/