Date: Tue, 24 Nov 2015 17:12:49 +0100
From: Piotr Kwapulinski <kwapulinski.piotr@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mhocko@suse.com, oleg@redhat.com, cmetcalf@ezchip.com, mszeredi@suse.cz,
        viro@zeniv.linux.org.uk, dave@stgolabs.net,
        kirill.shutemov@linux.intel.com, n-horiguchi@ah.jp.nec.com,
        aarcange@redhat.com, iamjoonsoo.kim@lge.com, jack@suse.cz,
        xiexiuqi@huawei.com, vbabka@suse.cz, Vineet.Gupta1@synopsys.com,
        riel@redhat.com, gang.chen.5i5j@gmail.com,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3] mm/mmap.c: remove incorrect MAP_FIXED flag comparison
 from mmap_region
Message-ID: <20151124161248.GA1414@home.local>
References: <20151123081946.GA21050@dhcp22.suse.cz>
 <1448300202-5004-1-git-send-email-kwapulinski.piotr@gmail.com>
 <20151123141401.0ad7e291be4d62ec83de7101@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151123141401.0ad7e291be4d62ec83de7101@linux-foundation.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1614
Lines: 42

On Mon, Nov 23, 2015 at 02:14:01PM -0800, Andrew Morton wrote:
> On Mon, 23 Nov 2015 18:36:42 +0100 Piotr Kwapulinski <kwapulinski.piotr@gmail.com> wrote:
> 
> > The following flag comparison in mmap_region makes no sense:
> > 
> > if (!(vm_flags & MAP_FIXED))
> >     return -ENOMEM;
> > 
> > The condition is always false and thus the above "return -ENOMEM" is never
> > executed. The vm_flags must not be compared with MAP_FIXED flag.
> > The vm_flags may only be compared with VM_* flags.
> > MAP_FIXED has the same value as VM_MAYREAD.
> > Hitting the rlimit is a slow path and find_vma_intersection should realize
> > that there is no overlapping VMA for !MAP_FIXED case pretty quickly.
> > 
> > Remove the code that makes no sense.
> > 
> > ...
> >
> > --- a/mm/mmap.c
> > +++ b/mm/mmap.c
> > @@ -1551,9 +1551,6 @@ unsigned long mmap_region(struct file *file, unsigned long addr,
> >  		 * MAP_FIXED may remove pages of mappings that intersects with
> >  		 * requested mapping. Account for the pages it would unmap.
> >  		 */
> > -		if (!(vm_flags & MAP_FIXED))
> > -			return -ENOMEM;
> > -
> >  		nr_pages = count_vma_pages_range(mm, addr, addr + len);
> >  
> >  		if (!may_expand_vm(mm, (len >> PAGE_SHIFT) - nr_pages))
> 
> Did you intend to retain the stale comment?

It was my intention. This comment is still valid, even after removing the
condition.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/