Date: Tue, 24 Nov 2015 16:46:42 +0000
From: Lee Jones <lee.jones@linaro.org>
To: LABBE Corentin <clabbe.montjoie@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: qcom_rpm: fix a possible NULL dereference
Message-ID: <20151124164642.GD12874@x1>
References: <1447314599-31460-1-git-send-email-clabbe.montjoie@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1447314599-31460-1-git-send-email-clabbe.montjoie@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1113
Lines: 36

On Thu, 12 Nov 2015, LABBE Corentin wrote:

> of_match_device could return NULL, and so cause a NULL pointer
> dereference later.
> 
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
> ---
>  drivers/mfd/qcom_rpm.c | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks.

> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
> index 207a3bd..1be47ad 100644
> --- a/drivers/mfd/qcom_rpm.c
> +++ b/drivers/mfd/qcom_rpm.c
> @@ -495,6 +495,8 @@ static int qcom_rpm_probe(struct platform_device *pdev)
>  	}
>  
>  	match = of_match_device(qcom_rpm_of_match, &pdev->dev);
> +	if (!match)
> +		return -ENODEV;
>  	rpm->data = match->data;
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/