Date: Tue, 24 Nov 2015 15:32:52 -0200
From: Gustavo Padovan <gustavo@padovan.org>
To: Greg Hackmann <ghackmann@google.com>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org, daniels@collabora.com,
        Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
        Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
        Riley Andrews <riandrews@android.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Rob Clark <robdclark@gmail.com>,
        John Harrison <John.C.Harrison@Intel.com>
Subject: Re: [PATCH] staging/android: add TODO to de-stage android sync
 framework
Message-ID: <20151124173252.GA14838@joana>
Mail-Followup-To: Gustavo Padovan <gustavo@padovan.org>,
	Greg Hackmann <ghackmann@google.com>, greg@kroah.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	daniels@collabora.com,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
	Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
	Riley Andrews <riandrews@android.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Rob Clark <robdclark@gmail.com>,
	John Harrison <John.C.Harrison@Intel.com>
References: <1448307713-16766-1-git-send-email-gustavo@padovan.org>
 <565495AC.9050008@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <565495AC.9050008@google.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1263
Lines: 30

2015-11-24 Greg Hackmann <ghackmann@google.com>:

> On 11/23/15 11:41 AM, Gustavo Padovan wrote:
> >+ - remove sw_sync, it is used only for testing/debugging and should not be
> >+upstreamed.
> >+ - port sw_sync testcases to use debugfs somehow
> 
> A quick but important nitpick:
> 
> sw_sync itself is just an in-kernel helper for creating fences, when you
> don't have something like sync timeline primitives baked into your hardware.
> 
> CONFIG_SW_SYNC_USER adds the interface for creating and signaling sw_sync
> objects from userspace.  This is the part that's dangerous and only intended
> for testing, etc.
> 
> AFAIK CONFIG_SW_SYNC_USER is the only part people have been objecting to.
> I'm fine with removing it.  Removing the kernel-facing side of sw_sync would
> be a problem for us, since many drivers use it to create their fences.

Right, I probably misundertood things, I'm okay with removing only
CONFIG_SW_SYNC_USER and if others are okay too I'll just send an updated
patch for the TODO.

	Gustavo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/