Subject: Re: [Qemu-devel] [PATCH v5 1/4] firmware: introduce sysfs driver for
 QEMU's fw_cfg device
To: "Gabriel L. Somlo" <somlo@cmu.edu>, kbuild test robot <lkp@intel.com>
References: <1448294264-17388-2-git-send-email-somlo@cmu.edu>
 <201511240404.AFpczj7x%fengguang.wu@intel.com>
 <20151124165553.GA22627@HEDWIG.INI.CMU.EDU>
Cc: mark.rutland@arm.com, peter.maydell@linaro.org, mst@redhat.com,
        stefanha@gmail.com, qemu-devel@nongnu.org, eric@anholt.net,
        kraxel@redhat.com, linux-api@vger.kernel.org, pawel.moll@arm.com,
        zajec5@gmail.com, galak@codeaurora.org, rmk+kernel@arm.linux.org.uk,
        lersek@redhat.com, hanjun.guo@linaro.org, devicetree@vger.kernel.org,
        arnd@arndb.de, ijc+devicetree@hellion.org.uk,
        jordan.l.justen@intel.com, agross@codeaurora.org,
        leif.lindholm@linaro.org, robh+dt@kernel.org,
        ard.biesheuvel@linaro.org, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, luto@amacapital.net, kbuild-all@01.org,
        sudeep.holla@arm.com, pbonzini@redhat.com, revol@free.fr
From: Eric Blake <eblake@redhat.com>
Openpgp: url=http://people.redhat.com/eblake/eblake.gpg
Organization: Red Hat, Inc.
Message-ID: <5654A08A.6030002@redhat.com>
Date: Tue, 24 Nov 2015 10:38:18 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151124165553.GA22627@HEDWIG.INI.CMU.EDU>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="sImjOk8MwI0j6lP7WkPsFtqx8wGB2nOe6"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3269
Lines: 85

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--sImjOk8MwI0j6lP7WkPsFtqx8wGB2nOe6
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 11/24/2015 09:55 AM, Gabriel L. Somlo wrote:
> On Tue, Nov 24, 2015 at 04:14:50AM +0800, kbuild test robot wrote:

>>
>>    drivers/firmware/qemu_fw_cfg.c: In function 'fw_cfg_cmdline_set':
>>>> drivers/firmware/qemu_fw_cfg.c:510:7: warning: format '%lli' expects=
 argument of type 'long long int *', but argument 3 has type 'phys_addr_t=
 *' [-Wformat=3D]
>>           &ctrl_off, &data_off, &consumed);
>>           ^
>=20
> Oh, I think I know why this happened:
>=20

>=20
> So, I could use u64 instead of phys_addr_t and resource_size_t, and
> keep "%lli" (or "%Li"), but then I'd have to check if the parsed value

%Li is not POSIX.  Don't use it (stick with %lli).

> would overflow a 32-bit address value on arches where phys_addr_t is
> u32, which would make things a bit more messy and awkward.
>=20
> I'm planning on #ifdef-ing the format string instead:
>=20
> #ifdef CONFIG_PHYS_ADDR_T_64BIT
> #define PH_ADDR_SCAN_FMT "@%Li%n:%Li:%Li%n"
> #else
> #define PH_ADDR_SCAN_FMT "@%li%n:%li:%li%n"
> #endif

A more typical approach is akin to <inttypes.h>; have PH_ADDR_FMT
defined to either "lli" or "li", then write sscanf(str, "@%"PH_ADDR_FMT
"%n:..., ...), using PH_ADDR_FMT multiple times.

> ...
>         processed =3D sscanf(str, PH_ADDR_SCAN_FMT,
>                            &base, &consumed,
>                            &ctrl_off, &data_off, &consumed);

Umm, why are you passing &consumed to more than one sscanf() %?  That's
(probably) undefined behavior.

[In general, sscanf() is a horrid interface to use for parsing integers
- it has undefined behavior if the input text would trigger integer
overflow, making it safe to use ONLY on text that you control and can
guarantee won't overflow. By the time you've figured out if untrusted
text meets the requirement for safe parsing via sscanf(), you've
practically already parsed it via safer strtol() and friends.]

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--sImjOk8MwI0j6lP7WkPsFtqx8wGB2nOe6
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJWVKCKAAoJEKeha0olJ0Nq4kgH/RnVbh6yH6EpDAFjVIauu0D7
0Z9gc2FHZuQhNBl1bCWXx8wtXKbDtsR2RRCIIEF/I0KWVLt2G6u9tyV5ywjnej8x
jAGQLpjR748H/H19vAHDp8U/v+6hpIfEscWjIFHwlMWzxOQ6cOLDTD24S/8CRhDf
/luUrFEkpzY4aL3o9aBlwcNjFv5lmdxU+TmehDcsAKXbJtC/ZvXku8j6umavfL+Z
Q0APbHZsG+gB9aA9w5nDMaubySkIe97rfrxqOROdFp1kK+IHpglIasWovYAoe4fJ
rBGlSDvP765pfq7PoK0od9W+FQ3ZsQma2PTiTs41kXrj+tOg1zmOhAEbbmpwEQQ=
=NNe0
-----END PGP SIGNATURE-----

--sImjOk8MwI0j6lP7WkPsFtqx8wGB2nOe6--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/