Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754795AbbKXSYL (ORCPT ); Tue, 24 Nov 2015 13:24:11 -0500 Received: from mail-lf0-f48.google.com ([209.85.215.48]:34283 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754171AbbKXSYJ (ORCPT ); Tue, 24 Nov 2015 13:24:09 -0500 Message-ID: <5654AB45.80204@bjorling.me> Date: Tue, 24 Nov 2015 19:24:05 +0100 From: =?UTF-8?B?TWF0aWFzIEJqw7hybGluZw==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Elliott, Robert (Persistent Memory)" , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "axboe@fb.com" CC: "hch@infradead.org" , "keith.busch@intel.com" , "sudipm.mukherjee@gmail.com" , "ww.tao0320@gmail.com" Subject: Re: [PATCH 1/5] lightnvm: change vendor and dev id for qemu References: <1448371608-18053-1-git-send-email-m@bjorling.me> <1448371608-18053-2-git-send-email-m@bjorling.me> <94D0CD8314A33A4D9D801C0FE68B40295BE51C85@G9W0745.americas.hpqcorp.net> In-Reply-To: <94D0CD8314A33A4D9D801C0FE68B40295BE51C85@G9W0745.americas.hpqcorp.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1141 Lines: 30 On 11/24/2015 04:52 PM, Elliott, Robert (Persistent Memory) wrote: > > >> -----Original Message----- >> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel- >> owner@vger.kernel.org] On Behalf Of Matias Bjørling >> Sent: Tuesday, November 24, 2015 7:27 AM > ... >> Instead of using the Intel NVMe QEMU instance vendor and device id, >> let's use a preallocated from CNEX Labs instead. This lets us > ... >> /* QEMU NVMe simulator - PCI ID + Vendor specific bit */ >> - if (pdev->vendor == PCI_VENDOR_ID_INTEL && pdev->device == >> 0x5845 && >> + if (pdev->vendor == 0x1d1d && pdev->device == 0x1f1f && >> id->vs[0] == 0x1) > > Could this patch add PCI_VENDOR_ID_CNEX to the appropriate .h file > and use that instead? We could. But it would only be for this single use-case? Might be a little overkill to put in pci_ids.h. Opt for lightnvm.h? or somewhere else? Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/