Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754885AbbKXSd6 (ORCPT ); Tue, 24 Nov 2015 13:33:58 -0500 Received: from smtp4-g21.free.fr ([212.27.42.4]:37748 "EHLO smtp4-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754080AbbKXSd5 (ORCPT ); Tue, 24 Nov 2015 13:33:57 -0500 Date: Tue, 24 Nov 2015 19:33:49 +0100 From: Alban To: Philipp Zabel Cc: Aban Bedel , linux-kernel@vger.kernel.org Subject: Re: [PATCH] reset: ath79: Add system restart support Message-ID: <20151124193349.6ddc4c0b@tock> In-Reply-To: <1448366506.3346.72.camel@pengutronix.de> References: <1448323233-29719-1-git-send-email-albeu@free.fr> <1448366506.3346.72.camel@pengutronix.de> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 976 Lines: 29 On Tue, 24 Nov 2015 13:01:46 +0100 Philipp Zabel wrote: > Hi Alban, > > Am Dienstag, den 24.11.2015, 01:00 +0100 schrieb Alban Bedel: > > Add a system restart handler that use the FULL_CHIP_RESET bit of the > > reset controller. > > > > Signed-off-by: Alban Bedel > > Applied, thanks. Thanks to you :) > Btw, should this driver #include for readl/writel? Good question :) It turns out to be a MIPS glitch, asm/io.h is included by asm/page.h which here come from linux/module.h. But we shouldn't rely on this glitch and the driver should #include . I'll fix this and add support for CONFIG_COMPILE_TEST to better catch this kind of bugs in the future. Alban -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/