Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754906AbbKXSeS (ORCPT ); Tue, 24 Nov 2015 13:34:18 -0500 Received: from gabe.freedesktop.org ([131.252.210.177]:47942 "EHLO gabe.freedesktop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754796AbbKXSeQ (ORCPT ); Tue, 24 Nov 2015 13:34:16 -0500 From: Eric Anholt To: Peter Ujfalusi , vinod.koul@intel.com, swarren@wwwdotorg.org, lee@kernel.org Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: bcm2835-dma: Convert to use DMA pool In-Reply-To: <1447672143-14201-1-git-send-email-peter.ujfalusi@ti.com> References: <1447672143-14201-1-git-send-email-peter.ujfalusi@ti.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 24 Nov 2015 10:34:13 -0800 Message-ID: <87poyztffe.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1948 Lines: 48 --=-=-= Content-Type: text/plain Peter Ujfalusi writes: > f93178291712 dmaengine: bcm2835-dma: Fix memory leak when stopping a > running transfer > > Fixed the memleak, but introduced another issue: the terminate_all callback > might be called with interrupts disabled and the dma_free_coherent() is > not allowed to be called when IRQs are disabled. > Convert the driver to use dma_pool_* for managing the list of control > blocks for the transfer. > > Fixes: f93178291712 ("dmaengine: bcm2835-dma: Fix memory leak when stopping a running transfer") > Signed-off-by: Peter Ujfalusi It sounds like you got positive testing feedback. Using the DMA pool for our bcm2835_dma_cbs makes sense to me, too. Reviewed-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJWVK2lAAoJELXWKTbR/J7oNqcQAIuvd4TlHuZGpgm/6v6Gtf5y 4mrMYgZ/lpTnoDgGsGHD7hyDgVCxJW6btJ7niz+7AA3rYcIl5TdySiwOUPGB2iZT JsWItrNYI+Q5nlsbiU+xsZ6P+pOXsZnsd6GFn/pDBbknlGRgBVY+KX8mVMNOOd45 KswaihTp9bDYYQa40WlOqV5uxPlIzZWD2SNpitghGQJ0lctQT4qeCOgUqu3Sdrq/ vyiWyysrDODnFx7YLGQBizKWw5hwUo+wzA5+hEZvz+zto0POYQq6pKBrpCM7/Sng PTCmg+5IHLeMArWESdtWE3Wj3ZBjpnLIKNOh4rK7Ja+GHQKlABTM+NjPH+lRX807 E+kv/DjpKPajORc3kWm7SC58LGyc4zM/bQpUVP2eFxuVcGUHjlNtVN28O8WrE3le JcNCpVJA1x0fHkNKHnZ2SANveSoj3lCevYCSR41l1BDTlBZiD+oFXqz2NYdKWLKE E3tyCIKttWB5xQop9HNGYEgv5QuWFvP+w/q1MHY4rrEKxfHK+utu8eOh75UrRKts +pjMf7eEHl5mRgHQKBwZuSrPxzkQChiDGQ6blGiJbb2ZbEDp1nap1kH9PDHLn25k pHs6RNCewDhRgK7ynZzvPlbIGWSc2cOkbpzFmwAka6MMTUCF5bzcnF1/v3I/su5o 1D/6QAnA8AvNWcFLk+nG =f5UD -----END PGP SIGNATURE----- --=-=-=-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/