Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755428AbbKXWRb (ORCPT ); Tue, 24 Nov 2015 17:17:31 -0500 Received: from mail-lf0-f48.google.com ([209.85.215.48]:35609 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754685AbbKXWR3 (ORCPT ); Tue, 24 Nov 2015 17:17:29 -0500 MIME-Version: 1.0 In-Reply-To: <2529008.Qej2ZWi12S@wuerfel> References: <1448360579-79260-1-git-send-email-andriy.shevchenko@linux.intel.com> <2529008.Qej2ZWi12S@wuerfel> Date: Tue, 24 Nov 2015 23:17:27 +0100 X-Google-Sender-Auth: XKXUe2m2mGYJmYvoLSXZH1RUyr4 Message-ID: Subject: Re: [PATCH v1 00/13] intel-lpss: support non-ACPI platforms From: "Rafael J. Wysocki" To: Arnd Bergmann Cc: Andy Shevchenko , "Rafael J. Wysocki" , Greg Kroah-Hartman , Jarkko Nikula , linux-i2c@vger.kernel.org, ACPI Devel Maling List , Linux Kernel Mailing List , Lee Jones , Mika Westerberg , Kevin Fenzi , Wolfram Sang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2248 Lines: 50 On Tue, Nov 24, 2015 at 9:00 PM, Arnd Bergmann wrote: > On Tuesday 24 November 2015 12:22:46 Andy Shevchenko wrote: >> This series includes few logical sets that bring a support of non-ACPI >> platforms for Intel Skylake. >> >> First part is a refactoring of built-in device properties support: >> - keep single value inside the structure >> - provide helper macros to define built-in properties >> - fall back to secondary fwnode if primary has no asked property >> >> Second one is modifications to MFD code and intel-lpss.c driver in particular >> to define and pass built-in properties to the individual drivers. >> >> Last part is a fix for I2C bug found on Lenovo Yoga hardware and a first >> converted user. >> >> Built-in device properties is an alternative to platform data. It provides a >> unified API that drivers can use to cover all cases at once: DT, ACPI, and >> built-in properties. >> >> With this series applied platform data can be considered obsolete. Moreover, >> built-in device properties allows to adjust existing configuration, for >> example, in cases when ACPI values are wrong on some platforms. >> >> The series has been tested on available hardware and doesn't break current >> behaviour. But we ask you, Kevin, to apply the series on your side and check >> with Lenovo hardware. > > I agree with Rafael, this looks really nice. I found one small thing that > could be improved, see the comment on patch 11. > > Aside from that, I think we should have a nicer way to pass a property > list through platform_device_info when calling > platform_device_register_full(). You don't do that here because the drivers > you change are based on MFD cells rather than direct platform devices, > but it would fit in the series and should be easy enough to do. > > I don't know why Rafael didn't do that for the initial series already, maybe > he had a good reason. I was focusing on the generics rather than on any particular individual bus type. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/