Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755364AbbKXWTl (ORCPT ); Tue, 24 Nov 2015 17:19:41 -0500 Received: from mail-lf0-f52.google.com ([209.85.215.52]:32999 "EHLO mail-lf0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754196AbbKXWTg (ORCPT ); Tue, 24 Nov 2015 17:19:36 -0500 MIME-Version: 1.0 In-Reply-To: <20151124164907.GA24819@localhost> References: <1447648057-13644-1-git-send-email-jiang.liu@linux.intel.com> <20151124164907.GA24819@localhost> Date: Tue, 24 Nov 2015 23:19:34 +0100 X-Google-Sender-Auth: Gmuc5qRgB7QNfYXqFZYvF_MjQ2Q Message-ID: Subject: Re: [Bugfix] x86/PCI: Fix regression caused by commit 4d6b4e69a245 From: "Rafael J. Wysocki" To: Bjorn Helgaas Cc: Jiang Liu , "Rafael J . Wysocki" , Bjorn Helgaas , Linux Kernel Mailing List , Linux PCI , ACPI Devel Maling List , x86@kernel.org, Keith Busch , Arthur Marsh Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1815 Lines: 40 On Tue, Nov 24, 2015 at 5:49 PM, Bjorn Helgaas wrote: > On Mon, Nov 16, 2015 at 12:27:37PM +0800, Jiang Liu wrote: >> From: Liu Jiang >> >> Commit 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support >> PCI host bridge") converted x86 to use the common interface >> acpi_pci_root_create, but the conversion missed on code piece in >> arch/x86/pci/bus_numa.c, which causes regression on some legacy >> AMD platforms as reported by Arthur Marsh . >> The root causes is that acpi_pci_root_create() fails to insert >> host bridge resources into iomem_resource/ioport_resource because >> x86_pci_root_bus_resources() has already inserted those resources. >> So change x86_pci_root_bus_resources() to not insert resources into >> iomem_resource/ioport_resource. > > Fixes: 4d6b4e69a245 ("x86/PCI/ACPI: Use common interface to support PCI host bridge") > >> Signed-off-by: Jiang Liu >> Reported-and-tested-by: Arthur Marsh > > What's the status of this? It looks like a regression we need to fix > for v4.4. > > AFAICT, Arthur did *not* test this patch (rather, his response says he > did test it and the test failed). > > 4d6b4e69a245 was merged by Rafael, and I assume he'll merge the fix > unless I hear otherwise. Quite frankly, I'm more likely to revert the offending commit at this point as that's not the only regression reported against it and the fix only helps in one case (out of three known to me). Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/