Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755407AbbKXWVk (ORCPT ); Tue, 24 Nov 2015 17:21:40 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:5656 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754376AbbKXWVf (ORCPT ); Tue, 24 Nov 2015 17:21:35 -0500 Subject: Re: [PATCH 1/5] lightnvm: change vendor and dev id for qemu To: =?UTF-8?Q?Matias_Bj=c3=b8rling?= , "Elliott, Robert (Persistent Memory)" , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <1448371608-18053-1-git-send-email-m@bjorling.me> <1448371608-18053-2-git-send-email-m@bjorling.me> <94D0CD8314A33A4D9D801C0FE68B40295BE51C85@G9W0745.americas.hpqcorp.net> <5654AB45.80204@bjorling.me> CC: "hch@infradead.org" , "keith.busch@intel.com" , "sudipm.mukherjee@gmail.com" , "ww.tao0320@gmail.com" From: Jens Axboe Message-ID: <5654E2CF.7090403@fb.com> Date: Tue, 24 Nov 2015 15:21:03 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5654AB45.80204@bjorling.me> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-11-24_14:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1361 Lines: 38 On 11/24/2015 11:24 AM, Matias Bjørling wrote: > On 11/24/2015 04:52 PM, Elliott, Robert (Persistent Memory) wrote: >> >> >>> -----Original Message----- >>> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel- >>> owner@vger.kernel.org] On Behalf Of Matias Bjørling >>> Sent: Tuesday, November 24, 2015 7:27 AM >> ... >>> Instead of using the Intel NVMe QEMU instance vendor and device id, >>> let's use a preallocated from CNEX Labs instead. This lets us >> ... >>> /* QEMU NVMe simulator - PCI ID + Vendor specific bit */ >>> - if (pdev->vendor == PCI_VENDOR_ID_INTEL && pdev->device == >>> 0x5845 && >>> + if (pdev->vendor == 0x1d1d && pdev->device == 0x1f1f && >>> id->vs[0] == 0x1) >> >> Could this patch add PCI_VENDOR_ID_CNEX to the appropriate .h file >> and use that instead? > > We could. But it would only be for this single use-case? Might be a > little overkill to put in pci_ids.h. Opt for lightnvm.h? or somewhere else? Or just add a comment, this: if (pdev->vendor == 0x1d1d && pdev->device == 0x1f1f means nothing to anyone. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/