Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932242AbbKXXRj (ORCPT ); Tue, 24 Nov 2015 18:17:39 -0500 Received: from down.free-electrons.com ([37.187.137.238]:34380 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752339AbbKXXRi (ORCPT ); Tue, 24 Nov 2015 18:17:38 -0500 Date: Wed, 25 Nov 2015 00:17:36 +0100 From: Alexandre Belloni To: Joshua Clayton Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/9] rtc-pcf2123: put the chip reset into a function Message-ID: <20151124231736.GF3950@piout.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1671 Lines: 53 On 04/11/2015 at 07:36:36 -0800, Joshua Clayton wrote : A commit message, even when simple is mandatory. > Signed-off-by: Joshua Clayton > --- > drivers/rtc/rtc-pcf2123.c | 64 ++++++++++++++++++++++++++--------------------- > 1 file changed, 36 insertions(+), 28 deletions(-) > > diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c > index 257ce7d..d3c1447 100644 > --- a/drivers/rtc/rtc-pcf2123.c > +++ b/drivers/rtc/rtc-pcf2123.c > @@ -260,6 +260,40 @@ static int pcf2123_rtc_set_time(struct device *dev, struct rtc_time *tm) > return 0; > } > > +static int pcf2123_reset(struct device *dev) > +{ > + int ret; > + u8 rxbuf[2]; > + > + ret = pcf2123_write_reg(dev, PCF2123_REG_CTRL1, CTRL1_SW_RESET); > + if (ret < 0) > + return ret; > + > + /* Stop the counter */ > + dev_dbg(dev, "stopping RTC\n"); > + ret = pcf2123_write_reg(dev, PCF2123_REG_CTRL1, CTRL1_STOP); > + if (ret < 0) > + return ret; > + > + /* See if the counter was actually stopped */ > + dev_dbg(dev, "checking for presence of RTC\n"); > + ret = pcf2123_read(dev, PCF2123_REG_CTRL1, rxbuf, sizeof(rxbuf)); > + if (ret < 0) > + return ret; > + > + dev_dbg(dev, "received data from RTC (0x%02X 0x%02X)\n", > + rxbuf[0], rxbuf[1]); This is not properly aligned (use checkpatch --strict) -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/