Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755563AbbKXX3M (ORCPT ); Tue, 24 Nov 2015 18:29:12 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:56415 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752284AbbKXX3L (ORCPT ); Tue, 24 Nov 2015 18:29:11 -0500 Date: Tue, 24 Nov 2015 15:29:10 -0800 From: Greg Kroah-Hartman To: Martyn Welch Cc: Egor Uleyskiy , Manohar Vanga , Trivial Patch Monkey , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: staging: vme: Fixed code style issues Message-ID: <20151124232910.GD17422@kroah.com> References: <1447444882-12017-1-git-send-email-egor.ulieiskii@gmail.com> <56466C68.4040302@welchs.me.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56466C68.4040302@welchs.me.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 851 Lines: 28 On Fri, Nov 13, 2015 at 11:04:08PM +0000, Martyn Welch wrote: > > > On 13/11/15 20:01, Egor Uleyskiy wrote: > >From: Egor Uleyskiy > > > >* Fixed indention > >* Deleted extra empty lines > >* Constructions that looks like > > card = kzalloc(sizeof(struct pio2_card), GFP_KERNEL); > > are changed to > > card = kzalloc(sizeof(*card), GFP_KERNEL); > Also: > > * Removing extra bracketing from uses of the address operator > * Use preferred null return check style Ick, not good, please break this up into individual patches, one-per-type-of-fix. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/