Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932583AbbKYC7Y (ORCPT ); Tue, 24 Nov 2015 21:59:24 -0500 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:45983 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932277AbbKYC7W (ORCPT ); Tue, 24 Nov 2015 21:59:22 -0500 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: iamjoonsoo.kim@lge.com X-Original-SENDERIP: 10.177.222.138 X-Original-MAILFROM: iamjoonsoo.kim@lge.com Date: Wed, 25 Nov 2015 11:59:47 +0900 From: Joonsoo Kim To: Vlastimil Babka Cc: Andrew Morton , Mel Gorman , Yaowei Bai , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/compaction: __compact_pgdat() code cleanuup Message-ID: <20151125025947.GD9563@js1304-P5Q-DELUXE> References: <1448346282-5435-1-git-send-email-iamjoonsoo.kim@lge.com> <565424AD.7030808@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <565424AD.7030808@suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1695 Lines: 50 On Tue, Nov 24, 2015 at 09:49:49AM +0100, Vlastimil Babka wrote: > On 11/24/2015 07:24 AM, Joonsoo Kim wrote: > >This patch uses is_via_compact_memory() to distinguish direct compaction. > >And it also reduces indentation on compaction_defer_reset > >by filtering failure case. There is no functional change. > > > >Signed-off-by: Joonsoo Kim > >--- > > mm/compaction.c | 15 +++++++++------ > > 1 file changed, 9 insertions(+), 6 deletions(-) > > > >diff --git a/mm/compaction.c b/mm/compaction.c > >index de3e1e7..2b1a15e 100644 > >--- a/mm/compaction.c > >+++ b/mm/compaction.c > >@@ -1658,14 +1658,17 @@ static void __compact_pgdat(pg_data_t *pgdat, struct compact_control *cc) > > !compaction_deferred(zone, cc->order)) > > compact_zone(zone, cc); > > > >- if (cc->order > 0) { > >- if (zone_watermark_ok(zone, cc->order, > >- low_wmark_pages(zone), 0, 0)) > >- compaction_defer_reset(zone, cc->order, false); > >- } > >- > > VM_BUG_ON(!list_empty(&cc->freepages)); > > VM_BUG_ON(!list_empty(&cc->migratepages)); > >+ > >+ if (is_via_compact_memory(cc->order)) > >+ continue; > > That's fine. > > >+ if (!zone_watermark_ok(zone, cc->order, > >+ low_wmark_pages(zone), 0, 0)) > >+ continue; > >+ > >+ compaction_defer_reset(zone, cc->order, false); > > Here I'd personally find the way of "if(watermark_ok) defer_reset()" > logic easier to follow. Okay. Will change it. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/