Message-ID: <87bnai8xnx.wl%kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Eduardo Valentin <edubezval@gmail.com>
CC: Zhang Rui <rui.zhang@intel.com>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, <linux-pm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Ryusuke Sakato <ryusuke.sakato.bx@renesas.com>,
        "osd2@lm.renesas.com" <osd2@lm.renesas.com>,
        <linux-sh@vger.kernel.org>
Subject: Re: [PATCH] thermal: rcar: enable to set tripN-temp via DT
In-Reply-To: <20151125034320.GA14278@localhost.localdomain>
References: <HK2PR04MB0804B55DC6CE36094AEF5162BC1C0@HK2PR04MB0804.apcprd04.prod.outlook.com>
	<564D14A1.70806@renesas.com>
	<87h9kiilbe.wl%kuninori.morimoto.gx@renesas.com>
	<56545CE5.3040502@renesas.com>
	<87mvu37wv2.wl%kuninori.morimoto.gx@renesas.com>
	<5655059C.40509@renesas.com>
	<87io4q97s7.wl%kuninori.morimoto.gx@renesas.com>
	<20151125034320.GA14278@localhost.localdomain>
User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset="US-ASCII"
Date: Wed, 25 Nov 2015 05:23:50 +0000
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2015 05:23:50.3444 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HKXPR06MB1013
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1951
Lines: 47


Hi Eduardo

Thank you for your feedback

> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > 
> > Current rcar thermal driver is using 90 degrees as trip temp, but it
> > should be based on each SoC / platform.
> > This patch enables to set trip temp via DT. (It uses db8500-thermal
> > style for it)
> > It will use 90 degrees as default trip temp if DT doesn't have it.
> > 
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> >  .../devicetree/bindings/thermal/rcar-thermal.txt   |  2 ++
> >  drivers/thermal/rcar_thermal.c                     | 34 ++++++++++++++++++++--
> >  2 files changed, 33 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/thermal/rcar-thermal.txt b/Documentation/devicetree/bindings/thermal/rcar-thermal.txt
> > index 332e625..6c57f7e 100644
> > --- a/Documentation/devicetree/bindings/thermal/rcar-thermal.txt
> > +++ b/Documentation/devicetree/bindings/thermal/rcar-thermal.txt
> > @@ -18,6 +18,8 @@ Required properties:
> >  Option properties:
> >  
> >  - interrupts		: use interrupt
> > +- tripN-temp		: temperature of trip point N. it will use 90000 as default
> > +			  if DT doesn't have tripN-temp
> 
> First of all, you are creating an entry with is specific to your driver.
> That requires it to use proper prefixing.
> 
> Besides, your property is already covered by of-thermal. Please convert
> your driver to use of-thermal, this way it will give you the flexibility
> to configure thermal data in DT.

I see, but we need to keep compatibility for non-DT SoC.
(This driver is used from both DT, non-DT SoC)

Then, I noticed we can use .set_trip_temp, and it is very enough for us.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/