Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752536AbbKYK2d (ORCPT ); Wed, 25 Nov 2015 05:28:33 -0500 Received: from mx2.suse.de ([195.135.220.15]:52128 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbbKYK2b (ORCPT ); Wed, 25 Nov 2015 05:28:31 -0500 Subject: Re: [PATCH v2 6/9] mm, debug: introduce dump_gfpflag_names() for symbolic printing of gfp_flags To: Joonsoo Kim References: <1448368581-6923-1-git-send-email-vbabka@suse.cz> <1448368581-6923-7-git-send-email-vbabka@suse.cz> <20151125081645.GC10494@js1304-P5Q-DELUXE> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Minchan Kim , Sasha Levin , "Kirill A. Shutemov" , Mel Gorman , Michal Hocko From: Vlastimil Babka Message-ID: <56558D4C.3060902@suse.cz> Date: Wed, 25 Nov 2015 11:28:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151125081645.GC10494@js1304-P5Q-DELUXE> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2432 Lines: 57 On 11/25/2015 09:16 AM, Joonsoo Kim wrote: > On Tue, Nov 24, 2015 at 01:36:18PM +0100, Vlastimil Babka wrote: >> --- a/include/trace/events/gfpflags.h >> +++ b/include/trace/events/gfpflags.h >> @@ -8,8 +8,8 @@ >> * >> * Thus most bits set go first. >> */ >> -#define show_gfp_flags(flags) \ >> - (flags) ? __print_flags(flags, "|", \ >> + >> +#define __def_gfpflag_names \ >> {(unsigned long)GFP_TRANSHUGE, "GFP_TRANSHUGE"}, \ >> {(unsigned long)GFP_HIGHUSER_MOVABLE, "GFP_HIGHUSER_MOVABLE"}, \ >> {(unsigned long)GFP_HIGHUSER, "GFP_HIGHUSER"}, \ >> @@ -19,9 +19,13 @@ >> {(unsigned long)GFP_NOFS, "GFP_NOFS"}, \ >> {(unsigned long)GFP_ATOMIC, "GFP_ATOMIC"}, \ >> {(unsigned long)GFP_NOIO, "GFP_NOIO"}, \ >> + {(unsigned long)GFP_NOWAIT, "GFP_NOWAIT"}, \ >> + {(unsigned long)__GFP_DMA, "GFP_DMA"}, \ >> + {(unsigned long)__GFP_DMA32, "GFP_DMA32"}, \ >> {(unsigned long)__GFP_HIGH, "GFP_HIGH"}, \ >> {(unsigned long)__GFP_ATOMIC, "GFP_ATOMIC"}, \ >> {(unsigned long)__GFP_IO, "GFP_IO"}, \ >> + {(unsigned long)__GFP_FS, "GFP_FS"}, \ >> {(unsigned long)__GFP_COLD, "GFP_COLD"}, \ >> {(unsigned long)__GFP_NOWARN, "GFP_NOWARN"}, \ >> {(unsigned long)__GFP_REPEAT, "GFP_REPEAT"}, \ >> @@ -36,8 +40,12 @@ >> {(unsigned long)__GFP_RECLAIMABLE, "GFP_RECLAIMABLE"}, \ >> {(unsigned long)__GFP_MOVABLE, "GFP_MOVABLE"}, \ >> {(unsigned long)__GFP_NOTRACK, "GFP_NOTRACK"}, \ >> + {(unsigned long)__GFP_WRITE, "GFP_WRITE"}, \ >> {(unsigned long)__GFP_DIRECT_RECLAIM, "GFP_DIRECT_RECLAIM"}, \ >> {(unsigned long)__GFP_KSWAPD_RECLAIM, "GFP_KSWAPD_RECLAIM"}, \ >> {(unsigned long)__GFP_OTHER_NODE, "GFP_OTHER_NODE"} \ >> - ) : "GFP_NOWAIT" >> >> +#define show_gfp_flags(flags) \ >> + (flags) ? __print_flags(flags, "|", \ >> + __def_gfpflag_names \ >> + ) : "none" > > How about moving this to gfp.h or something? > Now, we use it in out of tracepoints so there is no need to keep it > in include/trace/events/xxx. Hm I didn't want to pollute such widely included header with such defines. And show_gfp_flags shouldn't be there definitely as it depends on __print_flags. What do others think? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/