Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752519AbbKYKpV (ORCPT ); Wed, 25 Nov 2015 05:45:21 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:36452 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbbKYKpT (ORCPT ); Wed, 25 Nov 2015 05:45:19 -0500 Date: Wed, 25 Nov 2015 02:45:15 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Joonsoo Kim cc: Andrew Morton , Vlastimil Babka , Mel Gorman , Yaowei Bai , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Joonsoo Kim Subject: Re: [PATCH v2] mm/compaction: __compact_pgdat() code cleanuup In-Reply-To: <1448429172-24961-1-git-send-email-iamjoonsoo.kim@lge.com> Message-ID: References: <1448429172-24961-1-git-send-email-iamjoonsoo.kim@lge.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1923 Lines: 54 On Wed, 25 Nov 2015, Joonsoo Kim wrote: > This patch uses is_via_compact_memory() to distinguish direct compaction. When I think of "direct compaction", I think of compaction triggered for high-order allocations from the page allocator before direct reclaim. This is the opposite of being triggered for is_via_compact_memory(). > And it also reduces indentation on compaction_defer_reset > by filtering failure case. There is no functional change. > > Acked-by: Yaowei Bai > Signed-off-by: Joonsoo Kim > --- > mm/compaction.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index de3e1e7..01b1e5e 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1658,14 +1658,15 @@ static void __compact_pgdat(pg_data_t *pgdat, struct compact_control *cc) > !compaction_deferred(zone, cc->order)) > compact_zone(zone, cc); > > - if (cc->order > 0) { > - if (zone_watermark_ok(zone, cc->order, > - low_wmark_pages(zone), 0, 0)) > - compaction_defer_reset(zone, cc->order, false); > - } > - > VM_BUG_ON(!list_empty(&cc->freepages)); > VM_BUG_ON(!list_empty(&cc->migratepages)); > + > + if (is_via_compact_memory(cc->order)) > + continue; This will be the third call to is_via_compact_memory() in this function. Maybe just do const bool sysctl = is_via_compact_memory(cc->order); early in the function since it won't change during the iteration? (And maybe get rid of that extra newline that already exists at the beginning of the iteration? Otherwise: Acked-by: David Rientjes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/