Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752812AbbKYLFE (ORCPT ); Wed, 25 Nov 2015 06:05:04 -0500 Received: from mail-lf0-f48.google.com ([209.85.215.48]:33887 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752213AbbKYLEl (ORCPT ); Wed, 25 Nov 2015 06:04:41 -0500 MIME-Version: 1.0 In-Reply-To: <55F70236.1030306@kernel.dk> References: <1442250962-9906-1-git-send-email-catalin.marinas@arm.com> <55F70236.1030306@kernel.dk> From: William Dauchy Date: Wed, 25 Nov 2015 12:04:20 +0100 Message-ID: Subject: Re: [PATCH] block: kmemleak: Track the page allocations for struct request To: Jens Axboe Cc: Catalin Marinas , "linux-kernel@vger.kernel.org" , Christoph Hellwig , Bart Van Assche Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1514 Lines: 44 Hi Jens, On Mon, Sep 14, 2015 at 7:21 PM, Jens Axboe wrote: > On 09/14/2015 11:16 AM, Catalin Marinas wrote: >> >> The pages allocated for struct request contain pointers to other slab >> allocations (via ops->init_request). Since kmemleak does not track/scan >> page allocations, the slab objects will be reported as leaks (false >> positives). This patch adds kmemleak callbacks to allow tracking of such >> pages. >> >> Signed-off-by: Catalin Marinas >> Reported-by: Bart Van Assche >> Tested-by: Bart Van Assche >> Cc: Christoph Hellwig >> Cc: Jens Axboe >> --- >> >> Jens, >> >> I just realised that no-one has picked this patch up for -rc1. It was >> discussed here previously: >> >> >> http://lkml.kernel.org/r/20150803104309.GB4033@e104818-lin.cambridge.arm.com >> >> Since it touches the block layer, are you fine with merging it? > > > Yeah looks simple enough for me, not sure why it got missed. I'll add it for > 4.4-rc1, thanks. I saw the related kmemleaks reports on my v4.1.x kernel. Since it's actually fixing these wrong reports, do you think it could be a good candidate for -stable tree? Thanks, -- William -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/